Repository navigation
Treat an empty Statement.filters list as a scan instead of panicking - #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query encoder indexed filters[0] whenever filters was Some, so a statement with
Some(vec![])panicked the per-node query task with an out-of-bounds index, surfacing as a client error -1.Add a crate-private
Statement::filter()accessor that returns the first filter or None, and use it at every site that decides query vs. scan: the encoder, the query/scan metrics label, and the scan flag handed to theExecuteTaskfromquery_operateandquery_execute_udf. An empty list now behaves exactly like None everywhere.Adds
query_empty_filter_list_scans, which fails with the panic on the old encoder line and passes with the fix.