fix: asset-profile-page overwriting formData from displayed data. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Zuricos, thank you for this contribution. I Think that with the proposed update, it's no more possible to delete a sector. |
|
Hi @afadil , thanks for your feedback, I will look into it, probably this week, and will come back with a fix. |
Zuricos
force-pushed
the
fix/asset-profile-page-weight-formdata
branch
from
de101fe to
d8f26f3
Compare
|
Hi @afadil, This issue should now be resolved. However, I am unable to verify it on my end since I couldn't get the project to run locally, even when using the dev container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered a bug in the "asset-profile-page" component.
Currently, the displayed data in the input fields of sector:weight and country:weight are used when new entries are added.
I.e. this will cause that the weigth will be 18 instead of 0.179 after adding a new entry.
With this change, this should no longer happen.