feat: add gitagent format for cross-harness portability#833
feat: add gitagent format for cross-harness portability#833affaan-m merged 1 commit intoaffaan-m:mainfrom
Conversation
|
❌ Analysis Failed
Troubleshooting
Retry: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds three new repository artifacts: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Worth noting — gitagent has 970+ GitHub stars and growing. The standard is being adopted across the ecosystem with 10+ export adapters (Claude Code, Cursor, Copilot, OpenCode, OpenClaw, Codex, Gemini CLI, etc.) and PRs on repos like gstack (37K stars). Adding gitagent format to ECC would make the largest agent harness portable to every major platform automatically. |
Greptile SummaryThis PR adds three new files ( Several issues flagged in earlier review rounds have been addressed in this revision:
Remaining minor gap:
Confidence Score: 5/5Safe to merge — fully additive, no existing files modified, all P0/P1 issues from prior rounds resolved All previously raised P1-level concerns (inaccurate description, skill count mismatch, inconsistent model identifiers, missing frontmatter fields) have been addressed in this revision. The only remaining finding is a P2 documentation completeness gap (missing 80%+ coverage threshold in SOUL.md and RULES.md), which does not block merge. No files require special attention — the 80%+ coverage threshold omission in SOUL.md and RULES.md is a minor documentation gap only Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ECC Repository (source of truth)"] --> B["agent.yaml\n(gitagent manifest)"]
A --> C["SOUL.md\n(identity + principles)"]
A --> D["RULES.md\n(development rules)"]
A --> E["skills/*/SKILL.md\n(135 skills)"]
A --> F["agents/*.md\n(30 agents)"]
A --> G["commands/\n(60 commands)"]
A --> H["hooks/\n(automations)"]
B --> I["gitagent export"]
C --> I
D --> I
E --> I
F -.->|"not yet in manifest\n(remain authoritative)"| I
G -.->|"not yet in manifest\n(remain authoritative)"| I
H -.->|"not yet in manifest\n(remain authoritative)"| I
I --> J["cursor\n.cursor/rules/*.mdc"]
I --> K["copilot\n.github/agents/*.agent.md"]
I --> L["opencode\nAGENTS.md + opencode.json"]
I --> M["openclaw\nworkspaces"]
Reviews (4): Last reviewed commit: "feat: add gitagent format for cross-harn..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="RULES.md">
<violation number="1" location="RULES.md:14">
P1: The new sensitive-data rule is over-broad: forbidding all file paths conflicts with existing command/agent output contracts that require exact file paths for actionable diagnostics.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
RULES.md (1)
14-14: Clarify "file paths" in sensitive data guideline.The prohibition on "file paths" is ambiguous. Relative paths in code (e.g.,
src/config.js) are necessary and non-sensitive, while absolute system paths (e.g.,/home/user/.secrets/) or paths revealing system structure are sensitive. Consider specifying "absolute file paths" or "system file paths" for clarity.📝 Proposed clarification
-- Include sensitive data (API keys, tokens, file paths) in any output +- Include sensitive data (API keys, tokens, absolute file paths) in any output🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@RULES.md` at line 14, Update the RULES.md rule that currently reads "Include sensitive data (API keys, tokens, file paths) in any output" to clarify what "file paths" means by specifying "absolute or system file paths (e.g., /home/user/.secrets/) or any paths that reveal system structure or sensitive locations," while allowing non-sensitive relative project paths (e.g., src/config.js); ensure the revised wording replaces the original phrase "file paths" and leaves the rest of the rule intact so reviewers can clearly distinguish allowed relative paths from disallowed absolute/system paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@RULES.md`:
- Line 14: Update the RULES.md rule that currently reads "Include sensitive data
(API keys, tokens, file paths) in any output" to clarify what "file paths" means
by specifying "absolute or system file paths (e.g., /home/user/.secrets/) or any
paths that reveal system structure or sensitive locations," while allowing
non-sensitive relative project paths (e.g., src/config.js); ensure the revised
wording replaces the original phrase "file paths" and leaves the rest of the
rule intact so reviewers can clearly distinguish allowed relative paths from
disallowed absolute/system paths.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5c794771-d438-4472-a8e3-2cd1848d017e
📒 Files selected for processing (3)
RULES.mdSOUL.mdagent.yaml
|
thanks. queued for review. |
|
Analysis Failed
Troubleshooting
Retry: |
|
Addressed the Greptile review feedback:
Pushed as |
|
Analysis Failed
Troubleshooting
Retry: |
affaan-m
force-pushed
the
feat/gitagent-format
branch
from
2a8c222 to
7ff2f07
Compare
|
Analysis Failed
Troubleshooting
Retry: |
2 participants
Summary
Type
What this adds
agent.yamlSOUL.mdRULES.mdWhy gitagent?
From CONTRIBUTING.md:
With gitagent, this becomes automatic:
ECC's existing
skills/*/SKILL.mdfiles already use compatible frontmatter. This PR just adds the metadata layer that makes the full catalog portable.Testing
gitagent validatepasses on the agent definitiongitagent infoshows all 125 skillsChecklist
Refs #832
Summary by cubic
Adds
gitagentmetadata so ECC is a validgitagentagent and can export to all harnesses from one source of truth. Addresses #832 by replacing manual cross-harness sync with automatic exports; fully additive with no changes to existing files.New Features
agent.yaml— manifest with spec version, name/version 1.9.0, author/license, preferred modelclaude-opus-4-6(fallbackclaude-sonnet-4-6), tags, and full skills catalog; description notes native agents/commands/hooks remain authoritative while coverage expands.SOUL.md— identity, core principles, orchestration philosophy, and cross-harness vision (extracted from AGENTS.md).RULES.md— development rules and formats for agents/skills/hooks/commits; clarifies “no secrets or absolute/system paths” policy.Migration
gitagent export -f cursor|copilot|opencode|openclawto generate platform files; no other steps required.Written for commit 7ff2f07. Summary will update on new commits.
Summary by CodeRabbit
Documentation
Chores