-
Notifications
You must be signed in to change notification settings - Fork 250
Lemmata for if_then_else_
#2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taneb
reviewed
Jun 25, 2025
gallais
reviewed
Jun 25, 2025
6740db7
to
317ecfb
Compare
Taneb
reviewed
Jun 26, 2025
JacquesCarette
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
A lot of these generalize to partitions and piecewise functions. Which I should implement.
I'm dubious about the utility of the |
This (1) follows the style guide of having a line length limit of 72 characters and (2) increases readability because it enables immediately seeing which sub-terms of an if_then_else_ expression are substituted.
MatthewDaggitt
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
if_then_else_
a lot in one of our projects and it turned out that sometimes these basic lemmata onif_then_else_
are quite useful. While it is typically straightforward to resolveif_then_else_
expressions by pattern matching on the boolean condition instead, sometimes it is convenient to use these lemmata when anif_then_else_
occurs somewhere deep in an equational-reasoning chain.