Skip to content

ci: attach release job to npm-publish environment#18

Merged
jnsdls merged 1 commit intomainfrom
ci-release-npm-publish-environment
Apr 28, 2026
Merged

ci: attach release job to npm-publish environment#18
jnsdls merged 1 commit intomainfrom
ci-release-npm-publish-environment

Conversation

@jnsdls
Copy link
Copy Markdown
Member

@jnsdls jnsdls commented Apr 28, 2026

Summary

  • npm Trusted Publisher for @nebula-agents/electron-mcp is configured with Environment name: npm-publish, but the release job had no environment: key. The OIDC token therefore lacked the environment claim and pnpm changeset publish was rejected with E404 (run 25026312815).
  • Adds environment: npm-publish to the release job so the OIDC claims match what npm expects.
  • Requires the npm-publish GitHub Actions environment to exist in repo settings (Settings → Environments). Once created, the next push to main (or rerun of the failing workflow) should publish 0.1.0.

Verification

  • pnpm check
  • pnpm test:electron if Electron/CDP behavior changed

Summary by CodeRabbit

  • Chores
    • Updated release workflow infrastructure configuration for deployment environment management. No user-facing changes.

npm Trusted Publisher config requires the OIDC token to include an
environment claim of `npm-publish`; without it, `pnpm changeset publish`
fails with E404 on PUT to the registry.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

⚠️ No Changeset found

Latest commit: 8f6243e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d973f01f-4e4c-47b9-90ac-48250ac05edc

📥 Commits

Reviewing files that changed from the base of the PR and between 61aff92 and 8f6243e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow now declares an environment: npm-publish configuration on its release job, adding GitHub Environment scoping to control deployment permissions and secrets without modifying any existing publish steps or permissions.

Changes

Cohort / File(s) Summary
Workflow Environment Configuration
.github/workflows/release.yml
Added environment: npm-publish declaration to the release job to enforce GitHub Environment-level access controls for npm package publishing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-release-npm-publish-environment

Comment @coderabbitai help to get the list of available commands and usage tips.

@jnsdls jnsdls merged commit 91b2058 into main Apr 28, 2026
2 of 3 checks passed
@jnsdls jnsdls deleted the ci-release-npm-publish-environment branch April 28, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant