Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/agent-network-protocol/AgentConnect/security/code-scanning/1
To fix the problem, we should avoid logging the sensitive value
secret_key_jsonin clear text. Instead, we can log only non-sensitive information, such as the fact that the callback was invoked and which DIDs were involved, but omit or redact the secret. If it is necessary to log something about the secret for debugging, we can log a constant string (e.g., "[REDACTED]") or, if absolutely necessary, a hash or truncated version (but even this is discouraged for secrets). The change should be made in thesdk_short_term_key_callbackfunction inexamples/python/hosted_mode/sample_alice.py, specifically on line 27.No new imports or methods are required for a simple redaction.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.