Summary
The file browser routes resolve user-provided paths directly. Absolute paths and expanded home paths can escape MINIONS_HOME/workspace, even though the project documentation describes the file browser as operating on the workspace directory.
The server also listens on all interfaces by default and allows wildcard CORS, which makes the local API reachable from arbitrary browser origins while Minions is running.
Impact
A request to the file API can read, download, write, rename, or delete paths outside the workspace. Symlinks inside the workspace can also point to files outside the workspace unless real paths are checked.
Example affected surface:
GET /api/files/read?path=/absolute/path
GET /api/files/download?path=/absolute/path
PUT /api/files/write
PATCH /api/files/rename
DELETE /api/files
Suggested fix
Bind to loopback by default, reject browser requests whose Origin does not match the app host, and require every file API path to stay inside the Minions workspace. Existing paths should be checked with realpath so symlink escapes are blocked.
Summary
The file browser routes resolve user-provided paths directly. Absolute paths and expanded home paths can escape
MINIONS_HOME/workspace, even though the project documentation describes the file browser as operating on the workspace directory.The server also listens on all interfaces by default and allows wildcard CORS, which makes the local API reachable from arbitrary browser origins while Minions is running.
Impact
A request to the file API can read, download, write, rename, or delete paths outside the workspace. Symlinks inside the workspace can also point to files outside the workspace unless real paths are checked.
Example affected surface:
GET /api/files/read?path=/absolute/pathGET /api/files/download?path=/absolute/pathPUT /api/files/writePATCH /api/files/renameDELETE /api/filesSuggested fix
Bind to loopback by default, reject browser requests whose
Origindoes not match the app host, and require every file API path to stay inside the Minions workspace. Existing paths should be checked withrealpathso symlink escapes are blocked.