feat(unstable-v2): add cancelled variant to tool call and plan item statuses#1750
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new cancelled lifecycle state for both v2 tool calls and v2 plan items, updating the JSON schemas, Rust schema types, v1↔v2 conversion behavior, and protocol documentation to describe the new status.
Changes:
- Add
cancelledtoToolCallStatusandPlanEntryStatusin both stable and unstable v2 JSON schemas. - Update v2 protocol docs (including migration + draft docs) to document the new
cancelledstatus. - Update Rust v2 schema enums + tests, and ensure v2→v1 conversion correctly errors on the new unrepresentable v2 status.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schema/v2/schema.unstable.json | Adds cancelled to unstable v2 tool-call and plan-entry status enums. |
| schema/v2/schema.json | Adds cancelled to stable v2 tool-call and plan-entry status enums. |
| docs/rfds/v2/tool-call-updates.mdx | Clarifies v2→v1 conversion wording for tool-call updates. |
| docs/rfds/v2/plan-variants.mdx | Clarifies when v2 item-based plan updates can be lossily represented in v1. |
| docs/protocol/v2/tool-calls.mdx | Documents cancelled as a tool-call status in stable v2 docs. |
| docs/protocol/v2/schema.mdx | Documents cancelled for plan-entry and tool-call statuses in the rendered schema docs. |
| docs/protocol/v2/migration.mdx | Updates migration guidance to note cancelled was added to status. |
| docs/protocol/v2/draft/tool-calls.mdx | Documents cancelled as a tool-call status in draft v2 docs. |
| docs/protocol/v2/draft/schema.mdx | Documents cancelled for plan-entry and tool-call statuses in the draft rendered schema docs. |
| docs/protocol/v2/draft/agent-plan.mdx | Adds cancelled to the documented plan-entry status list (draft). |
| docs/protocol/v2/agent-plan.mdx | Adds cancelled to the documented plan-entry status list (stable). |
| agent-client-protocol-schema/src/v2/tool_call.rs | Adds ToolCallStatus::Cancelled + serde roundtrip test. |
| agent-client-protocol-schema/src/v2/plan.rs | Adds PlanEntryStatus::Cancelled + serde roundtrip test. |
| agent-client-protocol-schema/src/v2/conversion.rs | Ensures v2→v1 conversion errors for cancelled and adds coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.