Skip to content

refactor: rename 'id' to 'providerId' in serialization and requests to comply the spec #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anna239 merged 1 commit into from
Jul 8, 2026
+7 −4
Merged

refactor: rename 'id' to 'providerId' in serialization and requests to comply the spec #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions acp-model/src/commonMain/kotlin/com/agentclientprotocol/model/Requests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ public data class ListProvidersRequest(
@UnstableApi
@Serializable
public data class SetProvidersRequest(
val id: String,
@SerialName("providerId") val id: String,
val apiType: LlmProtocol,
val baseUrl: String,
val headers: Map<String, String>? = null,
Expand All @@ -539,7 +539,7 @@ public data class SetProvidersRequest(
@UnstableApi
@Serializable
public data class DisableProvidersRequest(
val id: String,
@SerialName("providerId") val id: String,
override val _meta: JsonElement? = null
) : AcpRequest

Expand Down Expand Up @@ -663,7 +663,7 @@ public data class ProviderCurrentConfig(
@UnstableApi
@Serializable
public data class ProviderInfo(
val id: String,
@SerialName("providerId") val id: String,
val supported: List<LlmProtocol>,
val required: Boolean,
val current: ProviderCurrentConfig? = null,
Expand Down
5 changes: 4 additions & 1 deletion acp-model/src/commonTest/kotlin/com/agentclientprotocol/model/ProvidersSerializationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ class ProvidersSerializationTest {
val encoded = ACPJson.encodeToString(ProviderInfo.serializer(), info)
val decoded = ACPJson.decodeFromString(ProviderInfo.serializer(), encoded)

assertTrue(encoded.contains("\"providerId\""))
assertFalse(encoded.contains("\"id\""))
assertEquals(info, decoded)
}

Expand All @@ -80,7 +82,7 @@ class ProvidersSerializationTest {
fun `incoming JSON with current null is accepted and mapped to disabled`() {
val payload = """
{
"id": "main",
"providerId": "main",
"supported": ["openai"],
"required": false,
"current": null
Expand All @@ -105,6 +107,7 @@ class ProvidersSerializationTest {
val withoutHeadersJson = ACPJson.encodeToString(SetProvidersRequest.serializer(), withoutHeaders)
val withoutHeadersDecoded = ACPJson.decodeFromString(SetProvidersRequest.serializer(), withoutHeadersJson)

assertTrue(withoutHeadersJson.contains("\"providerId\""))
assertFalse(withoutHeadersJson.contains("\"headers\""))
assertNull(withoutHeadersDecoded.headers)

Expand Down
Loading