feat(acp): map sent requests to application types#278
Merged
Conversation
benbrandt
enabled auto-merge (squash)
July 21, 2026 14:00
There was a problem hiding this comment.
Pull request overview
This PR extends the ACP JSON-RPC layer to support mapping a SentRequest’s successful JSON-RPC response into arbitrary application types (including types that do not implement JsonRpcResponse), using one-shot (FnOnce) mappers. This fits into the core protocol SDK by making response consumption more ergonomic and enabling richer application-layer typing without changing the wire protocol.
Changes:
- Generalize
SentRequestconsumption APIs to work with mapped (non-JsonRpcResponse) result types, and allowFnOncemapping/decoding closures. - Update response-consumption plumbing so mapped values can be consumed without requiring
Sendin cases where it’s not necessary. - Add an advanced JSON-RPC test covering mapping into an application type and consuming a non-
Sendmapped value on aLocalSet.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/agent-client-protocol/tests/jsonrpc_advanced.rs |
Adds a regression test validating SentRequest::map to application types and block_task() consumption of a mapped non-Send value. |
src/agent-client-protocol/src/jsonrpc.rs |
Updates SentRequest internals and APIs to support FnOnce mapping and mapped result consumption without requiring JsonRpcResponse. |
src/agent-client-protocol/CHANGELOG.md |
Documents the new SentRequest mapping/consumption capability in the Unreleased section. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.