Skip to content

feat(acp): map sent requests to application types#278

Merged
benbrandt merged 1 commit into
mainfrom
feat-sent-request-map
Jul 21, 2026
Merged

feat(acp): map sent requests to application types#278
benbrandt merged 1 commit into
mainfrom
feat-sent-request-map

Conversation

@benbrandt

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 21, 2026 14:00
@benbrandt
benbrandt enabled auto-merge (squash) July 21, 2026 14:00
@benbrandt
benbrandt merged commit cc4c57a into main Jul 21, 2026
15 checks passed
@benbrandt
benbrandt deleted the feat-sent-request-map branch July 21, 2026 14:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the ACP JSON-RPC layer to support mapping a SentRequest’s successful JSON-RPC response into arbitrary application types (including types that do not implement JsonRpcResponse), using one-shot (FnOnce) mappers. This fits into the core protocol SDK by making response consumption more ergonomic and enabling richer application-layer typing without changing the wire protocol.

Changes:

  • Generalize SentRequest consumption APIs to work with mapped (non-JsonRpcResponse) result types, and allow FnOnce mapping/decoding closures.
  • Update response-consumption plumbing so mapped values can be consumed without requiring Send in cases where it’s not necessary.
  • Add an advanced JSON-RPC test covering mapping into an application type and consuming a non-Send mapped value on a LocalSet.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/agent-client-protocol/tests/jsonrpc_advanced.rs Adds a regression test validating SentRequest::map to application types and block_task() consumption of a mapped non-Send value.
src/agent-client-protocol/src/jsonrpc.rs Updates SentRequest internals and APIs to support FnOnce mapping and mapped result consumption without requiring JsonRpcResponse.
src/agent-client-protocol/CHANGELOG.md Documents the new SentRequest mapping/consumption capability in the Unreleased section.

@acp-release-bot acp-release-bot Bot mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants