Configurable templates #1316
Open
Configurable templates #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: Create a folder `/config/collections/templates` and place your collection templates there.
aheinze
requested changes
Jul 10, 2020
| @@ -105,7 +105,12 @@ public function collection($name = null) { | |||
| // get field templates | |||
| $templates = []; | |||
|
|
|||
| foreach ($this->app->helper('fs')->ls('*.php', 'collections:fields-templates') as $file) { | |||
| $templatesPath = 'collections:fields-templates'; | |||
| if ($customTemplatesPath = $this->path('#config:collections/templates')) { | |||
There was a problem hiding this comment.
why not allow both? collect the paths in an array and then do a loop over the folders
There was a problem hiding this comment.
This was intentional to avoid naming conflicts and to have the ability to override the default template(s). If I choose to use custom templates I can still copy the core collection template to my template folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Singletons now have the same template functionality like collections, so existing singletons are proposed when hovering over "Add field" while creating a new singleton.
Collections and singletons can have custom templates in
#config:collections/templates/*.phpand#config:singletons/templates/*.php.For collections: If the custom config templates folder exists, the folder
collections:fields-templateswill be ignored.