[Automated] Draft docs (agentgateway): ext proc: handle fail open with body - #1106
Merged
Merged
Conversation
…h body Signed-off-by: GitHub Action <action@github.com>
kristin-kronstain-brown
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft a documentation change
agentgateway/agentgateway#3542 — ext proc: handle fail open with body
agentgateway/websiteWarnings
agentgateway/agentgateway#3542 - ext proc: handle fail open with body
agentgateway/agentgateway#3542 fixes ExtProc fail-open handling when the processor connection fails before streamed request-body processing starts. Requests that use
fullDuplexStreamedorFullDuplexStreamedbody processing now keep the original body and continue to the backend or upstream application underfailOpenorFailOpen.failClosedandFailClosedstill return an error. No new configuration field is added; the documented knobs are the existing failure mode and request body mode settings.How
agentgateway-3542was drafted, and what was not verifiedagentgateway/agentgateway#3542 - ext proc: handle fail open with body
Plan, and what changed it
diff.patchadds a test for an unavailable external processor with full-duplex streamed request bodies, where fail-open preserves the original body and fail-closed returns HTTP 500.Why a documentation change is necessary
The pull request changes what happens when an ExtProc connection fails before request-body streaming starts. Both target pages already document ExtProc failure modes and streamed body processing, but neither page said whether fail-open preserves the original request body in that setup-failure case. A reader configuring fail-open for availability would not know that the backend or upstream application receives the intact body.
What changed on disk
content/docs/standalone/main/documentation/configuration/traffic-management/extproc.md: Added an explicitfailure-modesanchor and documented fail-open body preservation forextProc.processingOptions.requestBodyMode: fullDuplexStreamed.content/docs/kubernetes/main/documentation/traffic-management/extproc.md: Added an explicitextproc-server-considerationsanchor and documented fail-open body preservation fortraffic.extProc.processingOptions.requestBodyMode: FullDuplexStreamed.The item has no
feature,breaking_change, ordeprecationkind, so automatic placement does not choose a release-note section.How to verify this change
host: "127.0.0.1:0",failureMode: failOpen, andprocessingOptions.requestBodyMode: fullDuplexStreamed. In Kubernetes, use an unavailabletraffic.extProc.backendRef,traffic.extProc.failureMode: FailOpen, andtraffic.extProc.processingOptions.requestBodyMode: FullDuplexStreamed.failClosedorFailClosedand send the same request again. The request should fail instead of reaching the backend or upstream application.Proposed release note
The item has no placement kind, so a reviewer must decide whether and where to place the note.
What was not verified
The configuration was not applied to a cluster or standalone gateway, so every command and behavior check in this report is unrun. The proposed release note was not placed automatically because the item has no release-note kind that
place_release_notes.pycan map to a section.Draft branch:
pr-tracker-draft-agentgateway-3542Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. Doc tests, link checking and the static checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Cloudflare Pages and DCO are GitHub Apps rather than Actions, so those two do run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.