Conversation
Contributor
Author
|
Requested by: Haakam Aujla |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="fern/pages/integrations/mpp.mdx">
<violation number="1" location="fern/pages/integrations/mpp.mdx:38">
P2: Disable MPP's default global fetch polyfill here. `AgentMailClient({ mppx })` already consumes `mppx.fetch`, so leaving the default on adds an unnecessary process-wide side effect for unrelated requests.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| const account = privateKeyToAccount(PRIVATE_KEY); | ||
|
|
||
| export const mppx = Mppx.create({ methods: [tempo({ account })] }); |
There was a problem hiding this comment.
P2: Disable MPP's default global fetch polyfill here. AgentMailClient({ mppx }) already consumes mppx.fetch, so leaving the default on adds an unnecessary process-wide side effect for unrelated requests.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At fern/pages/integrations/mpp.mdx, line 38:
<comment>Disable MPP's default global fetch polyfill here. `AgentMailClient({ mppx })` already consumes `mppx.fetch`, so leaving the default on adds an unnecessary process-wide side effect for unrelated requests.</comment>
<file context>
@@ -0,0 +1,83 @@
+
+const account = privateKeyToAccount(PRIVATE_KEY);
+
+export const mppx = Mppx.create({ methods: [tempo({ account })] });
+
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MPP (Stripe Machine Payments Protocol) integration page, modeled after the existing x402 integration.
Summary by cubic
Adds an MPP (Stripe Machine Payments Protocol) integration page to docs with a quickstart for
agentmail+mppx, updates the Integrations nav, and points MPP docs to mpp.dev. This helps users enable per-request payments without API keys.pages/integrations/mpp.mdxwith prerequisites, install (agentmail,mppx,viem), quickstart code, “How it works”, and resources (MPP docs on mpp.dev).fern/docs.yml(Integrations > MPP with credit-card icon).Written for commit 6a5d035. Summary will update on new commits.