Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
8 issues found across 27 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="fern/pages/knowledge-base/threaded-conversations.mdx">
<violation number="1" location="fern/pages/knowledge-base/threaded-conversations.mdx:109">
P3: This reply example omits `html`, which contradicts the earlier guidance to always send both `text` and `html`. Add the HTML payload so the example matches the documented requirement.</violation>
</file>
<file name="fern/pages/knowledge-base/domain-warming.mdx">
<violation number="1" location="fern/pages/knowledge-base/domain-warming.mdx:8">
P3: The SMTP credentials link is malformed (`/https://...`), which will render as a broken relative link. Use the absolute URL without the leading `/`.</violation>
</file>
<file name="fern/pages/knowledge-base/dns-route53.mdx">
<violation number="1" location="fern/pages/knowledge-base/dns-route53.mdx:59">
P2: This timing claim is misleading. Route 53 updates reach Route 53 name servers within ~60 seconds, but end‑user propagation can be longer due to DNS resolver caching. Rephrase to avoid implying a 1–5 minute end‑to‑end guarantee.</violation>
</file>
<file name="fern/pages/knowledge-base/emails-going-to-spam.mdx">
<violation number="1" location="fern/pages/knowledge-base/emails-going-to-spam.mdx:66">
P2: Remove the leading slash so the Discord invite resolves as an external link.</violation>
<violation number="2" location="fern/pages/knowledge-base/emails-going-to-spam.mdx:68">
P3: Add spacing (or split into two sentences) so the final line reads correctly.</violation>
</file>
<file name="fern/pages/knowledge-base/what-is-agentmail.mdx">
<violation number="1" location="fern/pages/knowledge-base/what-is-agentmail.mdx:7">
P3: The intro paragraph has multiple spelling/grammar errors that make the explanation hard to read; rewrite this line with correct wording.</violation>
<violation number="2" location="fern/pages/knowledge-base/what-is-agentmail.mdx:28">
P3: This bullet has grammar agreement errors (`first class user`, `They needs`), which weakens readability.</violation>
<violation number="3" location="fern/pages/knowledge-base/what-is-agentmail.mdx:34">
P3: Fix the typo in this heading (`platfroms` → `platforms`).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Collaborator
Author
|
@duharry0915 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
5 issues found across 27 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="fern/pages/knowledge-base/inbox-capabilities.mdx">
<violation number="1" location="fern/pages/knowledge-base/inbox-capabilities.mdx:85">
P2: Guard against an empty thread list before indexing `threads.threads[0]` in the example.</violation>
</file>
<file name="fern/pages/knowledge-base/spf-dkim-dmarc.mdx">
<violation number="1" location="fern/pages/knowledge-base/spf-dkim-dmarc.mdx:63">
P2: The DMARC `p=reject` explanation is incorrect: rejection is based on DMARC failure (typically when both SPF and DKIM fail alignment), not simply SPF or DKIM failing individually.</violation>
</file>
<file name="fern/pages/knowledge-base/allowlists-blocklists.mdx">
<violation number="1" location="fern/pages/knowledge-base/allowlists-blocklists.mdx:67">
P3: The Personal Agent description conflicts with the example below it ("from you" vs customer domains). Align the sentence with the shown example to avoid confusing setup guidance.</violation>
</file>
<file name="fern/pages/knowledge-base/rate-limits.mdx">
<violation number="1" location="fern/pages/knowledge-base/rate-limits.mdx:49">
P2: This guidance is misleading: `clientId` on inbox creation does not prevent duplicate `messages.send` retries. Clarify that send deduplication must be handled in app logic (or by draft workflow), while `clientId` only applies to create operations.</violation>
</file>
<file name="fern/docs.yml">
<violation number="1" location="fern/docs.yml:415">
P2: These API layout entries are duplicated. Keeping them twice will repeat the same sections in the API reference navigation. Remove the second set of `api-keys`, `pods`, and `organizations`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - websockets | ||
| - lists | ||
| - metrics | ||
| - api-keys |
There was a problem hiding this comment.
P2: These API layout entries are duplicated. Keeping them twice will repeat the same sections in the API reference navigation. Remove the second set of api-keys, pods, and organizations.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At fern/docs.yml, line 415:
<comment>These API layout entries are duplicated. Keeping them twice will repeat the same sections in the API reference navigation. Remove the second set of `api-keys`, `pods`, and `organizations`.</comment>
<file context>
@@ -406,4 +412,91 @@ navigation:
- websockets
- lists
- metrics
+ - api-keys
+ - pods
+ - organizations
</file context>
Collaborator
Author
There was a problem hiding this comment.
No it is correct. we want to put it there.
There was a problem hiding this comment.
Got it—leaving those entries as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Launches a new Knowledge Base with 24 developer-focused articles and a dedicated “KB” docs tab to improve setup, deliverability, and troubleshooting. Also renames the Agent onboarding page, adds redirects, and documents KB writing guidelines.
New Features
fern/docs.yml, including an introduction page with Cards.AGENTS.md(structure, SDK accuracy, linking, and categories).Refactors
/integrations/ai-onboarding→/integrations/agent-onboarding).fern/docs.ymland final copy/grammar fixes across KB pages.Written for commit 44d2231. Summary will update on new commits.