Skip to content

fix(install): restore mode-specific step routing#1042

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/install-step-skip-routing
Open

fix(install): restore mode-specific step routing#1042
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/install-step-skip-routing

Conversation

@RerankerGuo

Copy link
Copy Markdown
Contributor

What changed

  • let mode-specific installer steps reach their dedicated should_skip_step cases
  • preserve Keep-All upgrade behavior in each dedicated case
  • add a focused shell regression test for Quick Start, non-interactive, Embedded, Keep-All, and manual routing

Why

Bash case statements stop at the first matching pattern. The Keep-All pattern also listed step_manager_runtime, step_e2ee, step_docker_proxy, step_idle, and step_hostshare, so their later mode-specific cases were unreachable.

As a result, Quick Start did not skip four advanced prompts, the non-interactive routing contract failed for five steps, and Embedded mode did not skip Docker proxy configuration at the router level. Some step functions had defensive non-interactive guards, but Quick Start still reached interactive prompts and the routing helper contradicted its own rules.

Validation

  • the new test against origin/main fails 10 assertions (19/29 pass)
  • bash install/tests/test-step-routing.sh passes 29/29 on this branch
  • bash -n passes for every tracked shell script
  • ShellCheck error-level scan passes for both changed scripts
  • git diff --check

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=copaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=hermes)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr-2 / mgr=copaw / wk=copaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=openclaw / wk=openclaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=copaw / wk=hermes)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=copaw / wk=copaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction-2 / mgr=openclaw / wk=openclaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (controller-cr / mgr=openclaw / wk=openclaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=copaw)

Commit: 34a3b2a
Workflow run: #1668

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@RerankerGuo

Copy link
Copy Markdown
Contributor Author

CI attribution for head 34a3b2a, workflow run #1668:

  • Translation, change detection, the controller image, and all six downstream image builds passed.
  • I inspected the raw logs for all 10 failed integration jobs. Every job has exactly one empty AGENTTEAMS_LLM_API_KEY, one LLM API Key is required installer error, make test-embedded exiting with error 2, and zero integration-test start markers.
  • The installer stops in step_llm, before it reaches any of the mode-specific steps changed by this PR.

The remaining red checks are therefore the fork-secret bootstrap issue addressed by #1026, not a branch-specific failure. Locally, the focused routing regression fails 10 assertions on origin/main and passes all 29 assertions on this head; repository-wide shell syntax and changed-file error-level ShellCheck also pass.

@shiyiyue1102

Copy link
Copy Markdown
Collaborator

The installer routing bug is real, but the PR is not ready yet. The new test loads should_skip_step through source process substitution; on the supported macOS Bash 3 environment that producer races with source, so the function is missing and 23 assertions fail. Please change the test to load the function synchronously in a Bash-3-compatible way, rerun it on macOS and Linux, and update the branch so the currently failed required integration checks are green before final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants