fix(install): restore mode-specific step routing#1042
Conversation
|
CI attribution for head
The remaining red checks are therefore the fork-secret bootstrap issue addressed by #1026, not a branch-specific failure. Locally, the focused routing regression fails 10 assertions on |
|
The installer routing bug is real, but the PR is not ready yet. The new test loads should_skip_step through source process substitution; on the supported macOS Bash 3 environment that producer races with source, so the function is missing and 23 assertions fail. Please change the test to load the function synchronously in a Bash-3-compatible way, rerun it on macOS and Linux, and update the branch so the currently failed required integration checks are green before final review. |
What changed
should_skip_stepcasesWhy
Bash
casestatements stop at the first matching pattern. The Keep-All pattern also listedstep_manager_runtime,step_e2ee,step_docker_proxy,step_idle, andstep_hostshare, so their later mode-specific cases were unreachable.As a result, Quick Start did not skip four advanced prompts, the non-interactive routing contract failed for five steps, and Embedded mode did not skip Docker proxy configuration at the router level. Some step functions had defensive non-interactive guards, but Quick Start still reached interactive prompts and the routing helper contradicted its own rules.
Validation
origin/mainfails 10 assertions (19/29 pass)bash install/tests/test-step-routing.shpasses 29/29 on this branchbash -npasses for every tracked shell scriptgit diff --check