test: honor AgentTeams GitHub token env#1051
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Contributor
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-16 11:35:35 UTC |
Collaborator
|
This is a useful test-harness compatibility cleanup, but its standalone value is limited because it does not change runtime behavior. Before further review, please either link it to a concrete currently failing workflow caused by the GitHub token variable mismatch, or consolidate it with the related test-environment contract cleanup such as #1028. Keeping several small environment-variable test PRs separate adds more review and merge overhead than the changes justify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TEST_GITHUB_TOKEN, preferring the currentAGENTTEAMS_GITHUB_TOKENcontractProblem
The installers persist and pass
AGENTTEAMS_GITHUB_TOKEN, but integration tests 08-13 only recognizeTEST_GITHUB_TOKENor the retiredHICLAW_GITHUB_TOKEN. Running the suite with the generated AgentTeams env therefore reports that no GitHub token is configured and skips those tests.The normalization preserves explicit test overrides and the legacy variable while making the current installer output work directly.
Testing
origin/mainfails withexpected token canonical, got <empty>bash tests/unit/test-github-token-env.shAGENTTEAMS_GITHUB_TOKENreaches the later LLM prerequisite instead of the GitHub-token skipbash -n tests/lib/test-helpers.sh tests/run-all-tests.sh tests/unit/test-github-token-env.shshellcheck -S error tests/lib/test-helpers.sh tests/run-all-tests.sh tests/unit/test-github-token-env.shgit diff --check