fix(manager): reject MCP options during runtime switches#1053
Open
RerankerGuo wants to merge 2 commits into
Open
fix(manager): reject MCP options during runtime switches#1053RerankerGuo wants to merge 2 commits into
RerankerGuo wants to merge 2 commits into
Conversation
Contributor
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-16 12:34:56 UTC |
Collaborator
|
This fixes a real runtime-switch contract mismatch: MCP authorization cannot be forwarded through hiclaw update worker and must remain a separate operation. The current blocker is the conflict with the latest main branch. Please rebase, keep the diff limited to the wrapper, agent-facing documentation, focused test, and current changelog entry, then rerun manager/tests/test-update-worker-runtime.sh. Once the branch is clean and the focused test passes, this should be straightforward to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mcp-serverswith--runtimebefore invoking the controller CLIRoot cause
update-worker-config.shexposes--mcp-serversfor its in-place authorization path, but the runtime-switch branch forwarded the same option tohiclaw update worker. The Go CLI does not implement that flag and directs MCP server updates through a separate flow, so the documented combined command could not succeed.Validation
manager/tests/test-update-worker-runtime.sh(4/4 assertions)bash -nfor the changed script and testhiclaw update worker --helpcontract checkgit diff --check