You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@shiyiyue1102 Hi! SHARD_A openclaw/openclaw failed on this PR's CI. Same pattern as #984 — in the copaw/hermes case the hiclaw-worker-bob session directory does not exist at all and Manager never invoked hiclaw create worker --name bob. The flake has now been observed on copaw/hermes, copaw/copaw, and openclaw/openclaw across multiple PRs (#972, #973, #975, #976, #984, this one), and #976 is a docs-only PR with no runtime changes — confirming it's a test infrastructure flake rather than a branch-local regression.
This PR only touches the Worker hiclaw-sync shell script and a regression test; it does not affect Manager agent runtime or worker-create code paths. Could you re-run CI or merge if you agree the flake is unrelated?
Preventing a stale MinIO copy of openclaw.json from briefly overwriting the live Worker token is valuable. The current PR cannot be reviewed independently because it conflicts with main and includes stacked #985 and #1015 test commits. Please rebase onto the latest main branch and rebuild the PR so the diff contains only the file-sync change, its focused regression, and the required changelog entry. A behavioral test that proves the bulk mirror never replaces the local token would be stronger than only checking for an exclude string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiclaw-syncscript so bulkmc mirrorexcludesopenclaw.jsonopenclaw.jsoninto a temporary file and merge it into the local config afterwardopenclaw.jsonduring mirrorThis prevents the stale Matrix access token stored in MinIO from being briefly restored over the worker-local token during file-sync.
Fixes #809.
Verification
bash -n manager/agent/worker-agent/skills/file-sync/scripts/hiclaw-sync.sh tests/test-17-worker-config-verify.shgit diff --check--exclude "openclaw.json"in the file-sync scriptTemporary dependency
685ac4b); test: nudge team leader to coordinate in team room #1015 passed all builds and all 10 integration matrices.1bd7d85passed every build and all 10 integration matrices after the prior head hit the known SHARD_D/test-21 Leader coordination timeout fixed by test: nudge team leader to coordinate in team room #1015.