feat: add workspace interface#1942
Open
yuluo-yx wants to merge 2 commits into
Open
Conversation
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new io.agentscope.core.workspace.Workspace contract in agentscope-core, intended to represent an agent execution environment (sandbox lifecycle + instructions + MCP clients + skills + context offloading). It also updates the package-level documentation to reflect the new abstraction.
Changes:
- Added the
Workspaceinterface (plus related sandbox/offload/MCP/skills contracts) underio.agentscope.core.workspace. - Updated
package-info.javato describe the new workspace API surface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/workspace/Workspace.java | Adds the new workspace contract and supporting interfaces for lifecycle, offloading, MCP client management, and skill catalog operations. |
| agentscope-core/src/main/java/io/agentscope/core/workspace/package-info.java | Updates package docs to match the new Workspace contract. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
yuluo-yx
force-pushed
the
0626-yuluo/add-worksapce-interface
branch
from
1c8b45c to
f8f0f2f
Compare
zouyx
reviewed
Jun 26, 2026
zouyx
left a comment
zouyx
left a comment
Contributor
There was a problem hiding this comment.
我在设计层面有个问题想问问，如果这个概念是工作区的话，现在设计应该是在 sandbox 之上构建工作区。会不会存在 sandbox 内构建工作区？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.