Skip to content

fix(harness): propagate memoryConfig to general-purpose subagent #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dangzitou wants to merge 10 commits into from
Closed

fix(harness): propagate memoryConfig to general-purpose subagent #2616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f46d01f
Propagate parent memory config into general-purpose subagents
dangzitou Aug 7, 2026
c9c2455
test(harness): assert general-purpose subagent inherits memory config
dangzitou Aug 8, 2026
2c67ff9
test(harness): format memory config propagation test
dangzitou Aug 8, 2026
9094878
fix: format gp memory config test for spotless
dangzitou Aug 8, 2026
5910a35
test: relax general-purpose memory stream matcher
dangzitou Aug 8, 2026
77dd859
fix(harness): always propagate builder memoryConfig to GP child
dangzitou Aug 9, 2026
8b974d2
test(harness): adjust no-memory path assertion for implicit parent mo…
dangzitou Aug 9, 2026
c8b79b1
test(harness): align gp inheritance parent-model count with memory-co…
dangzitou Aug 9, 2026
aaf300c
test(harness): relax parent model stream count assertions for flush path
dangzitou Aug 9, 2026
3d3d720
Merge branch 'main' into chore/fix-general-purpose-memory-config-prop…
zouyx Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions agentscope-harness/src/main/java/io/agentscope/harness/agent/HarnessAgentBuilderSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import io.agentscope.harness.agent.filesystem.remote.store.NamespaceFactory;
import io.agentscope.harness.agent.filesystem.sandbox.SandboxBackedFilesystem;
import io.agentscope.harness.agent.filesystem.spec.LocalFilesystemSpec;
import io.agentscope.harness.agent.memory.MemoryConfig;
import io.agentscope.harness.agent.memory.compaction.CompactionConfig;
import io.agentscope.harness.agent.memory.compaction.ToolResultEvictionConfig;
import io.agentscope.harness.agent.middleware.DynamicSubagentsMiddleware;
Expand Down Expand Up @@ -311,6 +312,7 @@ static SubagentFactory buildGeneralPurposeFactory(
final boolean capturedAgentTracingLogEnabled = b.agentTracingLogEnabled;
final List<String> capturedAdditionalContextFiles = List.copyOf(b.additionalContextFiles);
final int capturedMaxContextTokens = b.maxContextTokens;
final MemoryConfig capturedMemoryConfig = b.memoryConfig;
// Propagate the parent's (distributed) state store so an exposed subagent can be
// re-materialized on another node / after a restart and still load its conversation
// history by sessionId. Null in purely local default deployments — children then keep
Expand Down Expand Up @@ -356,6 +358,7 @@ static SubagentFactory buildGeneralPurposeFactory(
if (capturedModelExec != null) sub.modelExecutionConfig(capturedModelExec);
if (capturedToolExec != null) sub.toolExecutionConfig(capturedToolExec);
if (capturedGenOpts != null) sub.generateOptions(capturedGenOpts);
sub.memory(capturedMemoryConfig);
if (capturedDisableCompaction) {
sub.disableCompaction();
} else if (capturedCompactionConfig != null) {
Expand Down
71 changes: 71 additions & 0 deletions agentscope-harness/src/test/java/io/agentscope/harness/agent/HarnessAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
import io.agentscope.harness.agent.filesystem.local.LocalFilesystem;
import io.agentscope.harness.agent.filesystem.remote.store.InMemoryStore;
import io.agentscope.harness.agent.filesystem.spec.RemoteFilesystemSpec;
import io.agentscope.harness.agent.memory.MemoryConfig;
import io.agentscope.harness.agent.memory.compaction.CompactionConfig;
import io.agentscope.harness.agent.middleware.AgentTraceMiddleware;
import io.agentscope.harness.agent.middleware.SubagentEntry;
Expand Down Expand Up @@ -1181,6 +1182,76 @@ void generalPurpose_mirrorCompactionConfig() throws Exception {
assertNotNull(child.getCompactionHook(), "CompactionHook should be mirrored to GP child");
}

@Test
void generalPurpose_inheritsMemoryConfig_fromParent() throws Exception {
Files.createDirectories(workspace);

Model parentModel = stubModel("ok");
Model memoryModel = mock(Model.class);
when(memoryModel.getModelName()).thenReturn("memory-model");
ChatResponse memoryChunk =
new ChatResponse(
"memory-id",
List.of(TextBlock.builder().text("memory-done").build()),
null,
Map.of(),
"stop");
when(memoryModel.stream(anyList(), anyList(), any())).thenReturn(Flux.just(memoryChunk));

MemoryConfig memoryConfig =
MemoryConfig.builder()
.model(memoryModel)
.consolidationMinGap(Duration.ofMinutes(1))
.build();

List<SubagentEntry> entries =
HarnessAgent.builder()
.model(parentModel)
.workspace(workspace)
.memory(memoryConfig)
.buildSubagentEntries(workspace);

HarnessAgent child =
(HarnessAgent)
entries.stream()
.filter(e -> "general-purpose".equals(e.name()))
.findFirst()
.orElseThrow()
.factory()
.create(RuntimeContext.empty());

child.call(userText("hi, keep this in memory"), RuntimeContext.empty()).block();

verify(memoryModel).stream(any(), any(), any());
verify(parentModel, atLeast(1)).stream(any(), any(), any());
}

@Test
void generalPurpose_withoutMemoryConfig_usesParentModelOnly() throws Exception {
Files.createDirectories(workspace);

Model parentModel = stubModel("ok");

List<SubagentEntry> entries =
HarnessAgent.builder()
.model(parentModel)
.workspace(workspace)
.buildSubagentEntries(workspace);

HarnessAgent child =
(HarnessAgent)
entries.stream()
.filter(e -> "general-purpose".equals(e.name()))
.findFirst()
.orElseThrow()
.factory()
.create(RuntimeContext.empty());

child.call(userText("hi, no memory config"), RuntimeContext.empty()).block();

verify(parentModel, atLeast(1)).stream(any(), any(), any());
}

// =========================================================================
// Multiple declarations → same definition workspace
// =========================================================================
Expand Down
Loading