-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handles multiple Keplr popup notifications simultaneously #58
Handles multiple Keplr popup notifications simultaneously #58
Conversation
@MANTRArob This looks good to me. Could we add a test for this change? It would also be helpful to include instructions for manual testing. Thank you! |
@rabi-siddique Could you give brief instructions on where to add these two items? Thanks. |
@MANTRArob You can add instructions for manual testing in the PR description. |
…or the notification to be dismissed to handled situation when 2 notifications are showing
e8609b8
to
df1b278
Compare
@rabi-siddique I added a new file to show that this method would still work with the existing flow defined in |
@rabi-siddique Removed unnecessary tests. I ran it locally against the sdk demo build |
Thank You @MANTRArob! |
Motivation and context
This handles the situation where Keplr popup displays two notifications simultaneously.
Typically, we expect that after one notification is accepted or approved, the popup should disappear without showing any further notifications.
This is most likely due to Keplr not having the info of the chain.
Does it fix any issue?
#(issue)
Other useful info
To test this, you could point the test to https://elaisee.mantrachain.io/ which uses MANTRA chain which is not available in Keplr 0.12.68 that the current dev branch is using.
Quality checklist