Skip to content

Don't Merge: temp commit to bring up reverse tunnels on docker containers with latest changes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
basundhara-c wants to merge 100 commits into
base: main
Choose a base branch
from
Open

Don't Merge: temp commit to bring up reverse tunnels on docker containers with latest changes #3

basundhara-c wants to merge 100 commits into from

Conversation

@basundhara-c
Copy link
Collaborator

@basundhara-c basundhara-c commented Jul 9, 2025

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

agrawroh and others added 17 commits July 2, 2025 15:59
@agrawroh
reverse connection tunnels
e6d3cdd 
Signed-off-by: Rohit Agrawal <[email protected]>
@agrawroh
initial 1
cc0cabe 
Signed-off-by: Rohit Agrawal <[email protected]>
@agrawroh
cleanup
7502c01 
Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c
fixes: reset file events to prevent segfault in case a file event is …
f2b79ba 
…triggered after closure, and fix string match for content length header

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
WIP: reverse conn initiation and test script to verify workflow
48305ea 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh
reverse connection tunnels
c7b8433 
Signed-off-by: Rohit Agrawal <[email protected]>
@agrawroh
initial 1
1e80774 
Signed-off-by: Rohit Agrawal <[email protected]>
@agrawroh
cleanup
ea6bc4d 
Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c @agrawroh
fixes: reset file events to prevent segfault in case a file event is …
3e76bca 
…triggered after closure, and fix string match for content length header

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c @agrawroh
WIP: reverse conn initiation and test script to verify workflow
dc28a02 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh
test
be25dcb
@basundhara-c
Fixes to get re-initiation working
49a2cff 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh
Merge branch 'feat-rev-conns-new' into feat-rev-conns-new
d492eb5
@agrawroh
Merge pull request #2 from basundhara-c/feat-rev-conns-new
8c113ba 
Fixes to get re-initiation working
@agrawroh
Merge branch 'feat-rev-conns-new' of github-agrawroh:agrawroh/envoy i…
8c6f02d 
…nto feat-rev-conns-new
@agrawroh
fix YAMLs
c06ba3f 
Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c
Bring up docker containers for onprem and cloud
137e409
@basundhara-c basundhara-c changed the title Temp commit: bring up reverse tunnels on docker containers with latest changes Don't Merge: temp commit to bring up reverse tunnels on docker containers with latest changes Jul 9, 2025
@basundhara-c basundhara-c requested a review from agrawroh as a code owner July 10, 2025 23:49
@basundhara-c
Nits to make test work
b93205d 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
reverse conn cluster should get host for node_id and add logic to par…
4db2872 
…se Host header

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
REVERSE_CONNECTION cluster should be able to parse SNI along with Hos…
05473a0 
…t header

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Backup config files to build envoy locally
acbba64 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
WIP: Reverse connection cluster test
66c4cb5 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Reverse Conn Address should return the downstream socket interface
c243f49 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Cleanup upstream stat collection
85ac26d 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Move reverse conn utility to extensions
d790af2 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Move classes and tests into separate files
2d37141 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
split classes into separate files, separate upstream files into its o…
318af79 
…wn directory, etc

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Fix format and cleanup imports
d28e5f3 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Move extra files to backup_files dir
0d70745 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Merge remote-tracking branch 'upstream/main' into feat-rev-conns-new
025dc09 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
reverse conn http filter: fix imports
01a229f 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
test commit: network filter
531f264 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
reverse conn cluster: fix imports
a352bd7 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
fix imports
dbd3b30 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
agrawroh and others added 16 commits September 2, 2025 20:05
@agrawroh @basundhara-c
addressed comments from @yanavlasov
88b397f 
Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c
Move RCConnectionWrapper out and small changes
fbf85ab 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
http filter changes
a8f2974 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
format files
c1dce98 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh @basundhara-c
filter: reverse tunnel network filter
5293d89 
Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c
Update cloud-envoy.yaml to use reverse tunnel network filter
96d29f0 
- Replace HTTP connection manager with reverse tunnel network filter
- Configure ping_interval, auto_close_connections, request_path, and request_method
- Remove HTTP-specific routing configuration

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Merge remote-tracking branch 'upstream/main' into feat-rev-conns-new
7aadab9 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
remove setSocketReused flag and detach http filter
c858b22 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Changes to reverse tunnel network filter
f3c6782 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Merge remote-tracking branch 'upstream/main' into feat-rev-conns-new
e5c8cd6 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh @basundhara-c
reverse_tunnel: add RPING echos in the downstream socket extension at…
0484e59 
… I/O

Signed-off-by: Rohit Agrawal <[email protected]>
@basundhara-c
fix ping reply logic in downstream_reverse_connection_io_handle, add …
2f8cdcf 
…unit tests

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
changes to reverse connection examples
6741fed 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
changes to reverse connection docs
5e41f1f 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
fixes to docs and format
ad4fefa 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@basundhara-c
Fixes and formatting
381b1f5 
Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh @basundhara-c
updates
01d4fb3 
Signed-off-by: Rohit Agrawal <[email protected]>

Signed-off-by: Basundhara Chakrabarty <[email protected]>
@agrawroh @basundhara-c
fixes
6ae49df 
Signed-off-by: Rohit Agrawal <[email protected]>

Signed-off-by: Basundhara Chakrabarty <[email protected]>
agrawroh added a commit that referenced this pull request Dec 16, 2025
@agrawroh
filesystem: Fix crash when watch callback returns error or throws (en…
06e40b2 
…voyproxy#42554)

## Description

Today, when a filesystem watch callback returns a non-OK status or
throws an exception, the error gets propagated to `FileEventImpl` which
uses `THROW_IF_NOT_OK`.

Since there's no exception handler in the `libevent` loop, this causes
`std::terminate` to be called, which crashes Envoy.

**Stack Trace:**
```
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.119][234999][warning][misc] [source/common/protobuf/message_validator_impl.cc:23] Deprecated field: type envoy.config.core.v3.HeaderValueOption Using deprecated option 'envoy.config.core.v3.HeaderValueOption.append' from file base.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.120][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '0_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.123][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '1_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.126][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '2_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.127][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '3_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.128][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '4_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.130][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '5_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.132][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener '6_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.134][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener 'mtls_untrusted_regional_transparent_tunnel_listener'
Dec 11 00:11:26 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:26.135][234999][info][upstream] [source/common/listener_manager/lds_api.cc:109] lds: add/update listener 'mtls_app_trusted_regional_transparent_tunnel_listener'
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.097][234999][critical][main] [source/exe/terminate_handler.cc:36] std::terminate called! Uncaught unknown exception, see trace.
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.097][234999][critical][backtrace] [./source/server/backtrace.h:113] Backtrace (use tools/stack_decode.py to get line numbers):
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.097][234999][critical][backtrace] [./source/server/backtrace.h:114] Envoy version: 5eaabe0bbaad4612cb85473cd151039d8f1a2760/1.34.2-dev/Clean/RELEASE/BoringSSL
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.097][234999][critical][backtrace] [./source/server/backtrace.h:116] Address mapping: 558d8afcc000-558d8ee2f000 /usr/local/bin/envoy
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.100][234999][critical][backtrace] [./source/server/backtrace.h:123] #0: [0x558d8da5784f]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.102][234999][critical][backtrace] [./source/server/backtrace.h:123] #1: [0x558d8edd8673]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.104][234999][critical][backtrace] [./source/server/backtrace.h:123] #2: [0x558d8e3b120b]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.106][234999][critical][backtrace] [./source/server/backtrace.h:121] #3: Envoy::Filesystem::WatcherImpl::onInotifyEvent() [0x558d8e3990c3]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.108][234999][critical][backtrace] [./source/server/backtrace.h:123] #4: [0x558d8e3998d2]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.109][234999][critical][backtrace] [./source/server/backtrace.h:123] #5: [0x558d8e393de6]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.111][234999][critical][backtrace] [./source/server/backtrace.h:121] #6: Envoy::Event::FileEventImpl::mergeInjectedEventsAndRunCb() [0x558d8e394eb5]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.113][234999][critical][backtrace] [./source/server/backtrace.h:123] #7: [0x558d8e710823]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.115][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#8: event_base_loop [0x558d8e70d4a1]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.117][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#9: Envoy::Server::InstanceBase::run() [0x558d8daa2b99]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.119][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#10: Envoy::MainCommonBase::run() [0x558d8da4327a]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.121][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#11: Envoy::MainCommon::main() [0x558d8da44234]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.123][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#12: main [0x558d8afcc11c]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.123][234999][critical][backtrace] [./source/server/backtrace.h:123] envoyproxy#13: [0x7f1d54073efb]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.123][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#14: __libc_start_main [0x7f1d54073fbb]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#15: _start [0x558d8afcc02e]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:129] Caught Aborted, suspect faulting address 0x395f7
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:113] Backtrace (use tools/stack_decode.py to get line numbers):
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:114] Envoy version: 5eaabe0bbaad4612cb85473cd151039d8f1a2760/1.34.2-dev/Clean/RELEASE/BoringSSL
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:116] Address mapping: 558d8afcc000-558d8ee2f000 /usr/local/bin/envoy
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:123] #0: [0x7f1d54089c90]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:121] #1: gsignal [0x7f1d54089bde]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.124][234999][critical][backtrace] [./source/server/backtrace.h:121] #2: abort [0x7f1d54072832]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.126][234999][critical][backtrace] [./source/server/backtrace.h:123] #3: [0x558d8da5785c]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.128][234999][critical][backtrace] [./source/server/backtrace.h:123] #4: [0x558d8edd8673]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.129][234999][critical][backtrace] [./source/server/backtrace.h:123] #5: [0x558d8e3b120b]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.129][234999][critical][backtrace] [./source/server/backtrace.h:121] #6: Envoy::Filesystem::WatcherImpl::onInotifyEvent() [0x558d8e3990c3]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.131][234999][critical][backtrace] [./source/server/backtrace.h:123] #7: [0x558d8e3998d2]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.133][234999][critical][backtrace] [./source/server/backtrace.h:123] envoyproxy#8: [0x558d8e393de6]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.133][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#9: Envoy::Event::FileEventImpl::mergeInjectedEventsAndRunCb() [0x558d8e394eb5]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:123] envoyproxy#10: [0x558d8e710823]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#11: event_base_loop [0x558d8e70d4a1]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#12: Envoy::Server::InstanceBase::run() [0x558d8daa2b99]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#13: Envoy::MainCommonBase::run() [0x558d8da4327a]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#14: Envoy::MainCommon::main() [0x558d8da44234]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#15: main [0x558d8afcc11c]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:123] envoyproxy#16: [0x7f1d54073efb]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#17: __libc_start_main [0x7f1d54073fbb]
Dec 11 00:11:30 dbletE9433T node-envoy[234999]: [2025-12-11 00:11:30.135][234999][critical][backtrace] [./source/server/backtrace.h:121] envoyproxy#18: _start [0x558d8afcc02e]
```

In this change, we are making the `inotify` and `kqueue` watchers handle
callback errors gracefully by catching any exceptions using
`TRY_ASSERT_MAIN_THREAD`, logging errors instead of propagating them and
always returning the `OkStatus` to the event loop.

---

**Commit Message:** filesystem: Fix crash when watch callback returns
error or throws
**Additional Description:** Make `inotify` and `kqueue` watchers handle
callback errors gracefully.
**Risk Level:** Low
**Testing:** CI
**Docs Changes:** N/A
**Release Notes:** N/A

---------

Signed-off-by: Rohit Agrawal <[email protected]>
Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agrawroh agrawroh Awaiting requested review from agrawroh agrawroh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@basundhara-c @agrawroh