-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: FileUpload download attribute #1938
base: usability-testing-feb-25
Are you sure you want to change the base?
Conversation
|
|
|
@@ -43,7 +43,12 @@ export const FileUploadExistingFile = ({ | |||
</Box> | |||
{href ? ( | |||
<Text breakWords paddingY={1.5}> | |||
<TextLink href={href} rel="noopener noreferrer" target="_blank"> | |||
<TextLink | |||
download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to have target="_blank"
otherwise it just tried to open it in the same tab
dac0e3d
to
21f7862
Compare
This demo adds the
download
attribute to existing file lists so the files download instead of opening in a new tab.Ultimately, this should be an option per instance/file.
View preview
Checklist
Preflight
accordion: Updated padding
ordocs: Updated header links
yarn changeset
. Learn more about change management.Testing
yarn test
to ensure tests are passing. If required, runyarn test -u
to update any generated snapshots.Documentation
Creating new component
docs/overview.mdx
anddocs/code.mdx
at a minimum)yarn
in the root of the repo to do this)docs/components/designSystemComponents.tsx
).storybook/stories/KitchenSink.tsx
)docs/playroom/snippets.ts
)figmaGalleryNodeId
to Docs (docs/components/pictograms/index.tsx
)docs/components/pictograms/index.tsx
)