-
Notifications
You must be signed in to change notification settings - Fork 281
Support native python enum generation #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looks like there's a coverage drop. Can that be resolved? |
Ah, probably after my recent amendments to this PR. Sure, I'll fix them and ping you |
|
@agronholm can you have a look now? |
Added PR credit for enum generation feature.
75d603e to
ebf4f1b
Compare
|
I'll review this tomorrow. |
|
@agronholm did you have a chance to review this PR? |
|
Doing that now. |
agronholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some change requests, questions and comments.
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Alex Grönholm <[email protected]>
agronholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this is the last round.
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Co-authored-by: Alex Grönholm <[email protected]>
Changes
Fixes #408
Adds Python enum generation for database enum types
Native database ENUMs
Regarding Synthetic ENUMs for VARCHAR columns with CHECK Constraints
Generated Code
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.