better autoconfigure and API#6
Conversation
|
I also added an example for doing multiple keyboards with one flake. It just uses the default configs from the qmk_firmware tree as the example code. |
|
Actually today I figured out how to do the LSP setup in a lot less janky way, so I'll add that shortly. |
|
I know this is a big rewrite so let me know if you'd rather not merge this, no hard feelings |
|
Hey! ✋ Sorry again about the delay. For some reason, I don't get any notifications when something happens on this particular repository. Anyway, thanks again for your contribution! I will take a look at it and let you know what I think 😸 |
agustinmista
left a comment
agustinmista
left a comment
There was a problem hiding this comment.
This is excellent! Thanks again for taking the time 😃
I'd be very happy to merge this asap, but first we need to go over a couple of questions, fixing a small bug, and some customary bikeshedding.
mrjones2014
force-pushed
the
mrj/push-vkttrwtuqplv
branch
from
3fcef00 to
809794b
Compare
|
okay @agustinmista I think I've addressed all your feedback now! |
| { | ||
| packages.default = compile { | ||
| nixcaps = inputs.nixcaps.lib.${system}; | ||
| ergodoz_ez = { |
There was a problem hiding this comment.
Probably a typo. I will fix it in post, no biggie.
| moonlander-compile-db = nixcaps.mkCompileDb moonlander; | ||
| togkey_pad_plus-compile-db = nixcaps.mkCompileDb togkey_pad_plus; |
There was a problem hiding this comment.
Could be a good idea to move these into a let inside the devShell definition in the future.
|
This is great. Thanks a lot! There's one CI job failing because the |
2 participants
See #1
This is quite a bit of refactoring, no need to take it all as-is, I'm happy to continue working on it till you're happy with it.
I left the LSP config out of this PR because that is pretty jank and not guaranteed to work outside of my own specific setup keyboards 😅 (but I think we can figure out how to do it in the long term)