Open
Conversation
When a loan is issued or returned update book stock accordingly
BREAKING: chnage book_cover type from file to URL
notify user for rejected book request
abdullahwaheed
requested changes
Feb 14, 2023
Collaborator
abdullahwaheed
left a comment
abdullahwaheed
left a comment
There was a problem hiding this comment.
overall great work and i am really impressed 👏
there are some suggestions though. feel free to reach me out if you need some help
Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com>
add related names change models choice fields type to small int
…nto add-core-app
Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com>
…nto add-core-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add core app and user authentication. App include; Book, BookLoan, BookRequest, and Librarian and their migrations, views, serializers, and URLs.
There's a cron job for sending emails for overdue books.
Also a management command for importing books from CSV.
Why?
These changes complete the basic library CRUD and authentication.
How
User authentication is implemented using Djoser and simplejwt.
Roles and permissions are managed by a librarian table.
Over due books email are sent using a cron job which runs at 10 everyday.