Skip to content

Commit

Permalink
Get rid of the patdiff dependency
Browse files Browse the repository at this point in the history
Unfortunately it recursively depends on `core_unix`, which is not super portable.
So it's nice that we don't need it anymore.
  • Loading branch information
lukstafi committed Jan 30, 2025
1 parent af79521 commit 53b55f8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions dune-project
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,6 @@
ppx_expect
(ppx_minidebug
(>= 2.0.3))
; Cannot make it (patdiff :with-test), because `dune build -p neural_nets_lib @install`
; builds the tutorials target from dune/test, despite it being inline_tests!
(patdiff
(>= v0.15.0))
(odoc :with-doc)
(md2mld :with-doc))
(tags
Expand Down
1 change: 0 additions & 1 deletion neural_nets_lib.opam
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ depends: [
"ppx_variants_conv"
"ppx_expect"
"ppx_minidebug" {>= "2.0.3"}
"patdiff" {>= "v0.15.0"}
"odoc" {with-doc}
"md2mld" {with-doc}
]
Expand Down
2 changes: 1 addition & 1 deletion test/dune
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
(package neural_nets_lib)
(inline_tests
(deps ocannl_config))
(libraries base dynlink patdiff.expect_test_patdiff ocannl)
(libraries base dynlink ocannl)
(modules
einsum_trivia
hello_world_op
Expand Down

0 comments on commit 53b55f8

Please sign in to comment.