fix: GPU telemetry endpoint reachability logging + fix tests that weren't asserting properly #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU telemetry endpoint reachability logging
Problem
When the default DCGM endpoints (
localhost:9400andlocalhost:9401) were reachable, the system logged "2/0 endpoints reachable" instead of "2/2 endpoints reachable".Root Cause
The
_compute_endpoints_for_displaymethod intelemetry_manager.pyreturned an empty list when_user_explicitly_configured_telemetrywas False, causingendpoints_configuredto be empty even ifendpoints_reachablecontained 2 endpoints.Fix
Updated the endpoint display logic to show reachable default endpoints regardless of configuration method:
Testing
test_configure_sends_enabled_status_when_endpoints_reachableandtest_configure_no_shutdown_when_no_endpoints_reachable