-
Couldn't load subscription status.
- Fork 663
build: Add prometheus_client dependency for pip install without container #3794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ute without container
WalkthroughA new dependency, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permissive license is a go.
Overview:
prometheus_clienttodynamo.commonwhich is automatically imported when trying to runpython -m dynamo.frontenddynamo/container/deps/requirements.txt
Line 27 in 237e978
pip installfor local development outside of container was now missing this dependency.Details:
Error before this change when following local development pip install steps: https://github.com/ai-dynamo/dynamo?tab=readme-ov-file#developing-locally
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit