Skip to content

Conversation

@nv-tusharma
Copy link
Contributor

@nv-tusharma nv-tusharma commented Oct 28, 2025

Overview:

Closes OPS-1525
For Dynamo release, v0.6.1, we want to bump the NIXL version to 0.7.0. This PR bumps the NIXL version and relies on CI to validate functionality.

Details:

  • bump nixl version in pyproject.toml, cargo.toml.
  • update support_matrix to reflect the bump
  • Bump NIXL in Dockerfile

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated NIXL dependency from version 0.6.0 to 0.7.0 across build and runtime configurations.

Signed-off-by: Tushar Sharma <[email protected]>
@nv-tusharma nv-tusharma requested review from a team as code owners October 28, 2025 16:48
@github-actions github-actions bot added the chore label Oct 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

NIXL dependency version uniformly upgraded from 0.6.0 to 0.7.0 across build configurations, documentation, and dependency manifests (Dockerfile, build script, Cargo.toml, pyproject.toml, and support matrix).

Changes

Cohort / File(s) Summary
Build Configuration
container/Dockerfile, container/build.sh
NIXL_REF argument updated from 0.6.0 to 0.7.0
Rust Dependencies
lib/llm/Cargo.toml
nixl-sys dependency constraint updated from "=0.6.0" to "=0.7.0"
Python Dependencies
pyproject.toml
nixl dependency constraint bumped from <=0.6.0 to <=0.7.0 in vllm and sglang optional dependency groups
Documentation
docs/reference/support-matrix.md
NIXL version updated from 0.6.0 to 0.7.0 in GPU Runtime Dependency and Build Dependency tables

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify version bump is consistently applied across all 5 files
  • Confirm no breaking changes are introduced in NIXL 0.7.0 release notes (if available)

Poem

🐰 Hop, hop, the version's up!
From 0.6 to 0.7 we sup,
Config files all aligned,
Dependency bumps refined!

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "chore: bump nixl verison to 0.7.0" is directly related to the main change in the changeset. The raw summary confirms that the primary modification across all files is updating the NIXL dependency version from 0.6.0 to 0.7.0, which is exactly what the title communicates. The title is concise, follows conventional commit format, and clearly summarizes the primary change. Note: There is a minor spelling error ("verison" should be "version"), but this does not affect the clarity or relevance of the title.
Description Check ✅ Passed The pull request description includes three of the four required template sections: Overview, Details, and Related Issues. The Overview section clearly explains the context (Dynamo v0.6.1 release) and intent (NIXL version bump with CI validation). The Details section lists the specific files modified with appropriate bullet points. The Related Issues section mentions OPS-1525. However, the "Where should the reviewer start?" section is missing from the description, though the specific files that should be reviewed are already mentioned in the Details section. Overall, the description is mostly complete with all critical information present and well-organized.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c78b590 and f368984.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • lib/bindings/python/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • container/Dockerfile (1 hunks)
  • container/build.sh (1 hunks)
  • docs/reference/support-matrix.md (1 hunks)
  • lib/llm/Cargo.toml (1 hunks)
  • pyproject.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.
📚 Learning: 2025-07-30T00:34:35.810Z
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.

Applied to files:

  • docs/reference/support-matrix.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: trtllm (arm64)
  • GitHub Check: vllm (arm64)
  • GitHub Check: operator (amd64)
  • GitHub Check: sglang
  • GitHub Check: operator (arm64)
  • GitHub Check: tests (lib/bindings/python)
  • GitHub Check: tests (.)
  • GitHub Check: clippy (lib/bindings/python)
  • GitHub Check: tests (lib/runtime/examples)
  • GitHub Check: clippy (launch/dynamo-run)
  • GitHub Check: tests (launch/dynamo-run)
  • GitHub Check: clippy (.)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (5)
pyproject.toml (1)

55-65: NIXL constraint updates applied consistently across optional dependencies.

Both vllm and sglang optional dependency groups have been correctly updated to allow nixl <=0.7.0. The use of a loose upper-bound constraint is appropriate for Python packages and permits patch-level updates.

docs/reference/support-matrix.md (1)

55-71: Support matrix documentation correctly updated for NIXL 0.7.0.

Both the Runtime Dependency and Build Dependency sections have been updated to reflect NIXL 0.7.0. The version parity across runtime and build dependencies is consistent with this coordinated release.

lib/llm/Cargo.toml (1)

96-100: Rust system binding pinned to exact version 0.7.0 appropriately.

The nixl-sys dependency uses an exact version constraint (=0.7.0), which is the correct strategy for Rust system bindings that require ABI stability. This differs appropriately from the loose constraint in pyproject.toml (<=0.7.0), which is suitable for Python packages.

container/build.sh (1)

118-120: Build script NIXL reference updated and properly propagated.

Line 118 correctly updates NIXL_REF to 0.7.0. The variable is properly propagated as a Docker build argument (line 521) and passed to the TensorRT-LLM wheel builder script (line 677), ensuring consistent version usage throughout the build pipeline.

container/Dockerfile (1)

39-41: Dockerfile NIXL_REF build argument correctly updated.

Line 41 properly updates the NIXL_REF argument to 0.7.0. The variable is correctly redeclared for the base stage (line 60) and used to fetch the correct NIXL source branch during the build (line 224).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nv-tusharma
Copy link
Contributor Author

/ok to test 3e9cb3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants