feat: Image decoder in the frontend #3971
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Milesi <[email protected]>
milesial
changed the title
Signed-off-by: Alexandre Milesi <[email protected]>
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
1255231 to
cbe3353
Compare
milesial
requested review from
ayushag-nv,
grahamking,
indrajit96,
krishung5 and
rmccorm4
Signed-off-by: Alexandre Milesi <[email protected]>
krishung5
reviewed
Oct 30, 2025
| testing-nixl = ["dep:nixl-sys"] | ||
| testing-etcd = [] | ||
| block-manager = ["dep:nixl-sys", "dep:cudarc", "dep:ndarray", "dep:nix", "dep:aligned-vec"] | ||
| block-manager = ["dep:nixl-sys", "dep:cudarc", "dep:nix", "dep:aligned-vec"] |
There was a problem hiding this comment.
qq - why is the dep:ndarray removed here?
There was a problem hiding this comment.
Before it was optional based on the block-manager feature. Now it's always there for the frontend anyway, not optional, so block-manager will always have it too. See line 147
krishung5
approved these changes
Oct 30, 2025
Signed-off-by: Alexandre Milesi <[email protected]>
Signed-off-by: Alexandre Milesi <[email protected]>
milesial
force-pushed
the
alexandrem/frontend-image-decoding
branch
from
cbe3353 to
5be5da0
Compare
milesial
force-pushed
the
alexandrem/frontend-media-fetching
branch
from
11fe8e2 to
8a17e40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
See #3630 for context, this MR is a subset of it, focusing on image decoding, building on top of #3967.
E2E plumbing will be done in a followup MR, the current behavior of URL passthrough stays the default.