Skip to content

Conversation

@aschilling-nv
Copy link
Contributor

@aschilling-nv aschilling-nv commented Oct 30, 2025

Overview:

Adds 33 redirects to the conf.py from #3658.

Details:

Creating additional redirects to ensure users are routed to the correct location in the documentation.

Where should the reviewer start?

docs/conf.py

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated redirect mappings to ensure legacy documentation links properly resolve to current documentation pages.

@aschilling-nv aschilling-nv requested review from a team as code owners October 30, 2025 15:54
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi aschilling-nv! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Oct 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Walkthrough

The pull request adds multiple redirect mappings to the documentation configuration file, enabling old documentation paths to route to new locations. These include API documentation, development guides, architecture documentation, and other resources across various domains.

Changes

Cohort / File(s) Change Summary
Documentation Configuration Redirects
docs/conf.py
Added approximately 20+ new redirect mappings to the redirects dictionary, including entries for API/nixl_connect pages, backend/runtime guides, architecture/kvbm documentation, health/logging/metrics guides, Dynamo CLI, glossary, and router README. Mappings reference PR #3802 and #3658. No existing redirects were removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify each redirect mapping resolves correct old-to-new documentation paths
  • Ensure URL path syntax is consistent with existing entries
  • Confirm no duplicate keys or conflicting redirects with prior entries

Poem

🐰 Through winding docs the redirects now hop,
Old paths leading where new gardens bloom,
Architecture, guides, and APIs abound,
Each breadcrumb trail finds its way home. 🌿✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "docs: Adding redirects to correct PR 3658 moves" is directly and clearly related to the main change in the changeset. The raw summary confirms that the primary modification involves adding 33 new redirect mappings to docs/conf.py, which is exactly what the title describes. The title is concise, specific, and includes a reference to the related PR, enabling reviewers to quickly understand the purpose of the changes.
Description Check ✅ Passed The pull request description follows the required template structure with all four major sections present: Overview, Details, Where should the reviewer start, and Related Issues. The Overview clearly states the purpose (adding 33 redirects from PR #3658), the Details explain the goal (routing users correctly), and the reviewer start point is identified (docs/conf.py). While the Related Issues section contains a placeholder "#xxx", this is a minor non-critical issue, and the description is otherwise complete and informative, adequately conveying the intent and scope of the changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bec8b3 and 21c7b54.

📒 Files selected for processing (1)
  • docs/conf.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
docs/conf.py (1)

53-86: All redirect target paths are valid and properly mapped.

Verification confirms that all 33 redirect entries reference documentation source files that exist in the codebase. The redirects are correctly configured and will not result in broken links.

@nv-anants
Copy link
Contributor

/ok to test 1753f83

@nv-anants
Copy link
Contributor

/ok to test 3c02d2a

@kmkelle-nv kmkelle-nv enabled auto-merge (squash) October 30, 2025 21:27
@kmkelle-nv kmkelle-nv merged commit f2a3c63 into ai-dynamo:main Oct 30, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs external-contribution Pull request is from an external contributor size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants