chore: relax DynamoStatLoggerPublisher.record() signature

[GuanLuo]

To be resilient to uninterested upstream signature changes

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

Summary by CodeRabbit

• Refactor
  • Enhanced internal logging infrastructure compatibility for improved extensibility.

---

Note: This release includes internal improvements with no user-facing changes or new functionality.

[coderabbitai]

Walkthrough

Method signatures for record in NullStatLogger and DynamoStatLoggerPublisher classes are expanded to accept arbitrary positional and keyword arguments (*args, **kwargs). Existing parameters and behavior remain unchanged; additional arguments are disregarded, providing compatibility with future callers.

Changes

Cohort / File(s)	Summary
Method signature expansion for record methods components/src/dynamo/vllm/publisher.py	Added *args, **kwargs parameters to NullStatLogger.record() and DynamoStatLoggerPublisher.record() to accept arbitrary extra arguments without functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Verify that the signature expansion maintains backward compatibility with existing callers
• Confirm that the ignored extra arguments do not mask any intended functionality

Poem

🐰 Two methods grow whiskers so fine,
With *args and **kwargs divine,
They flex and they bend,
Yet mean just the same—
Compatibility woven with style! 🎀

Pre-merge checks

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description follows the required template structure but fails to fill in the substantive content sections. While the opening line "To be resilient to uninterested upstream signature changes" provides some context about intent, the Overview, Details, and "Where should the reviewer start?" sections are all empty with only placeholder comments remaining. The Related Issues section contains the unfilled placeholder "- closes GitHub issue: #xxx". The author essentially submitted the template with all content sections left blank, providing no actual explanation of the changes, their rationale, or implementation details.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "chore: relax DynamoStatLoggerPublisher.record() signature" directly and specifically describes the main change in the changeset. The changes expand the method signatures of both NullStatLogger.record() and DynamoStatLoggerPublisher.record() to accept *args and **kwargs, which is precisely what "relaxing" the signature means. The title is concise, clear, and specific enough that a teammate can immediately understand the primary change without needing additional context.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bec8b3 and df633be.

📒 Files selected for processing (1)

• components/src/dynamo/vllm/publisher.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-25T23:24:42.076Z

Learnt from: tzulingk
PR: ai-dynamo/dynamo#2666
File: components/backends/trtllm/src/dynamo/trtllm/publisher.py:0-0
Timestamp: 2025-08-25T23:24:42.076Z
Learning: WorkerMetricsPublisher.create_endpoint method signature has been updated in _core.pyi to include metrics_labels parameter: `def create_endpoint(self, component: str, metrics_labels: Optional[List[Tuple[str, str]]] = None)`, making the metrics_labels parameter optional with default value of None.

Applied to files:

• components/src/dynamo/vllm/publisher.py

🪛 Ruff (0.14.2)

components/src/dynamo/vllm/publisher.py

66-66: Unused method argument: args

(ARG002)

---

67-67: Unused method argument: kwargs

(ARG002)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Build and Test - dynamo
• GitHub Check: operator (amd64)
• GitHub Check: vllm (arm64)
• GitHub Check: sglang (arm64)

🔇 Additional comments (1)

components/src/dynamo/vllm/publisher.py (1)

61-68: LGTM! Good defensive programming for forward compatibility.

Adding *args, **kwargs correctly achieves the PR objective of being resilient to upstream signature changes. The static analysis warnings about unused parameters are expected and can be safely ignored—these parameters are intentionally unused to maintain compatibility with future callers.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}