feat: allow dynamic port in scripts in preparation for parallel testing (part 1) #4546
+98
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keivenchang
changed the title
keivenchang
changed the title
… (part 1)
Remove hardcoded --http-port=8000 flags from launch scripts. Frontend now
accepts either --http-port flag or DYN_HTTP_PORT env var (defaults to 8000).
Add DYN_SYSTEM_PORT fallback syntax ${DYN_SYSTEM_PORT:-8081} for worker ports.
Multi-worker scenarios use distinct env vars (DYN_SYSTEM_PORT_PREFILL,
DYN_SYSTEM_PORT_DECODE, DYN_SYSTEM_PORT_WORKER1, etc).
This enables flexible port configuration in preparation for parallel testing
while maintaining backward compatibility.
Related: DIS-1022
Signed-off-by: Keiven Chang <[email protected]>
keivenchang
force-pushed
the
keivenchang/DIS-1022__frontend-worker-dynamic-ports
branch
from
b0a27eb to
d3195ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds environment variable support for dynamic port configuration in preparation for parallel testing. Removes hardcoded --http-port=8000 flags from launch scripts, allowing frontend and workers to use configurable ports via environment variables while maintaining backward compatibility with CLI flags and default values.
Details:
Where should the reviewer start?
examples/backends/vllm/launch/agg.sh(typical single-worker pattern)examples/backends/sglang/launch/agg_router.sh(2 workers)Related Issues:
Relates to DIS-1022
/coderabbit profile chill