Repository navigation
Conversation
Signed-off-by: aknvda <anikkulkarni@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real Guard recovery test can fail while restoring a G3 block because its ordinary ctypes destination is not aligned for
O_DIRECT. Linux returnsEINVALeven though the file offset and length are aligned.Overallocate the test buffer and expose a page-aligned ctypes view of the original extent. Keep the allocation alive through replacement shutdown. Production code, direct I/O, and byte-verification assertions are unchanged.
Validation: reproduced the original failure against unchanged main with
io_geteventsreturning-EINVAL; a controlled aligned-buffer run passed. With this fixture change, both real-NIXL Guard recovery parameterizations pass on Linux. The combined NVTX branch plus this isolated fixture fix passes 500 tests, with 1 skipped.