fix(claude-code): replace cross-spawn with native child_process for Node.js v24 compatibility #65
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode.js v24 compatibility The CLI was failing on Node.js v24 with: "Error: Dynamic require of 'child_process' is not supported" This occurred because cross-spawn uses dynamic require() for native Node modules, which ESM bundles don't support in Node.js v24. Changes: - Replace cross-spawn with native node:child_process spawn - Remove cross-spawn and @types/cross-spawn dependencies Fixes CLI startup on Node.js v24+
|
@alexismunoz1 is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
tt-a1i
approved these changes
Dec 10, 2025
Contributor
tt-a1i
left a comment
tt-a1i
left a comment
There was a problem hiding this comment.
LGTM! The native spawn works fine here since it's just spawning node + a .js file, not a Windows .cmd wrapper. Makes sense to drop the extra dependency.
tt-a1i
reviewed
Dec 10, 2025
Contributor
tt-a1i
left a comment
tt-a1i
left a comment
There was a problem hiding this comment.
Withdrawing my earlier approval - want to take another look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLI startup failure on Node.js v24+
Problem
The CLI fails on Node.js v24 with:
This occurs because
cross-spawnuses dynamicrequire()for native Node modules, which ESM bundles don't support in Node.js v24.Solution
cross-spawnwith nativenode:child_processspawncross-spawnand@types/cross-spawndependenciesThe native
spawnworks identically for this use case (spawning the server process).Testing
Workaround for users
Use version 0.0.70:
npx @react-grab/[email protected]