-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): bump idc-index-data from 22.1.5 to 23.0.1 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [idc-index-data](https://github.com/ImagingDataCommons/idc-index-data) from 22.1.5 to 23.0.1. - [Release notes](https://github.com/ImagingDataCommons/idc-index-data/releases) - [Commits](ImagingDataCommons/idc-index-data@22.1.5...23.0.1) --- updated-dependencies: - dependency-name: idc-index-data dependency-version: 23.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @dependabot[bot]'s task —— View job Dependency Update Review: idc-index-data 22.1.5 → 23.0.1 ✅SummaryVerdict: APPROVE with monitoring recommendation This is a routine data release update from the NCI Imaging Data Commons (IDC) with low breaking change risk. The major version bump (v22 → v23) reflects the underlying IDC data release version, not an API breaking change. Change DetailsDependency: Release Notes:
Risk Assessment✅ LOW RISK - Data Update, Not API ChangeWhat Changed:
Integration Points (Verified Stable): # src/aignostics/third_party/idc_index.py uses:
import idc_index_data
# Stable attributes used:
idc_index_data.__version__ # ✅ Standard attribute
idc_index_data.IDC_INDEX_PARQUET_FILEPATH # ✅ Stable constant
idc_index_data.PRIOR_VERSIONS_INDEX_PARQUET_FILEPATH # ✅ Stable constant
# Version parsing (adapts to major version):
self.idc_version = f"v{Version(idc_index_data.__version__).major}" # ✅ Now returns "v23"Why This is Safe:
📋 Test CoverageDataset module tests: 20 tests across 3 files ✅
All tests properly marked with required markers ( CI/CD Status
Note: Tests are still running but expected to pass based on:
Code Quality Checks✅ No Critical Issues FoundConventional Commits: ✅ PASS
Test Markers: ✅ PASS (all 20 tests properly marked) Type Checking: ✅ PASS (no changes to code, only dependency version) Architecture Compliance: ✅ PASS (no code changes) Recommendations✅ Approve and MergeRationale:
📊 Post-Merge MonitoringWhile risk is low, monitor these areas after deployment:
Test Commands: # After merge, verify dataset operations:
uv run aignostics dataset idc collections
uv run pytest -m "e2e and dataset" -v
# Check version detection:
python3 -c "from aignostics.third_party.idc_index import IDCClient; c=IDCClient.client(); print(f'IDC Version: {c.idc_version}')"
# Expected output: "IDC Version: v23"Medical Device Compliance✅ No Regulatory Impact
Final Verdict✅ APPROVE - Low-Risk Data Update This is a routine dependency update for the IDC v23 data release. The package is essentially a data bundle (Parquet index files) with stable API surface. No breaking changes detected. Action Items:
Questions/Concerns: None identified. This is a standard data release update following semantic versioning where major version tracks IDC data release version. |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|



Bumps idc-index-data from 22.1.5 to 23.0.1.
Release notes
Sourced from idc-index-data's releases.
Commits
810fcedenh: update to IDC v232264f3cenh: add missing descriptionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)