Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2025

Bumps idc-index-data from 22.1.5 to 23.0.1.

Release notes

Sourced from idc-index-data's releases.

23.0.1

What's Changed

Full Changelog: ImagingDataCommons/idc-index-data@23.0.0...23.0.1

23.0.0

What's Changed

Full Changelog: ImagingDataCommons/idc-index-data@22.1.5...23.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [idc-index-data](https://github.com/ImagingDataCommons/idc-index-data) from 22.1.5 to 23.0.1.
- [Release notes](https://github.com/ImagingDataCommons/idc-index-data/releases)
- [Commits](ImagingDataCommons/idc-index-data@22.1.5...23.0.1)

---
updated-dependencies:
- dependency-name: idc-index-data
  dependency-version: 23.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added bot Automated pull requests or issues dependabot Pull requests from Dependabot dependencies Pull requests that update a dependency file skip:test:long_running Skip long-running tests (≥5min) labels Nov 22, 2025
@dependabot dependabot bot added dependencies Pull requests that update a dependency file bot Automated pull requests or issues dependabot Pull requests from Dependabot skip:test:long_running Skip long-running tests (≥5min) labels Nov 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Claude finished @dependabot[bot]'s task —— View job


Dependency Update Review: idc-index-data 22.1.5 → 23.0.1 ✅

Summary

Verdict: APPROVE with monitoring recommendation

This is a routine data release update from the NCI Imaging Data Commons (IDC) with low breaking change risk. The major version bump (v22 → v23) reflects the underlying IDC data release version, not an API breaking change.


Change Details

Dependency: idc-index-data
Version Change: 22.1.523.0.1
Release Date: November 21, 2025
Type: IDC v23 data release + metadata enhancements

Release Notes:

  • v23.0.1 (Nov 21): Update to IDC v23 data release
  • v23.0.0 (Nov 21): IDC v23 data release + add missing descriptions
  • Commits:
    • 810fced - "enh: update to IDC v23"
    • 2264f3c - "enh: add missing descriptions"

Risk Assessment

LOW RISK - Data Update, Not API Change

What Changed:

  • Data files: Updated Parquet index files reflecting IDC v23 cancer imaging dataset
  • Metadata: Added missing collection descriptions
  • No API changes: Module interface remains stable

Integration Points (Verified Stable):

# src/aignostics/third_party/idc_index.py uses:
import idc_index_data

# Stable attributes used:
idc_index_data.__version__                          # ✅ Standard attribute
idc_index_data.IDC_INDEX_PARQUET_FILEPATH          # ✅ Stable constant
idc_index_data.PRIOR_VERSIONS_INDEX_PARQUET_FILEPATH # ✅ Stable constant

# Version parsing (adapts to major version):
self.idc_version = f"v{Version(idc_index_data.__version__).major}"  # ✅ Now returns "v23"

Why This is Safe:

  1. Data bundle package - Primarily ships Parquet index files, not code APIs
  2. No breaking API changes - Release notes mention only "enhancements" and "updates"
  3. Semantic versioning reflects data version - v23 = IDC data release v23, not breaking API
  4. Stable interface - SDK uses only standard attributes (__version__, file path constants)
  5. Version-adaptive code - SDK extracts major version dynamically (v23 from 23.0.1)

📋 Test Coverage

Dataset module tests: 20 tests across 3 files

  • tests/aignostics/dataset/cli_test.py - 12 tests
  • tests/aignostics/dataset/service_test.py - 4 tests
  • tests/aignostics/dataset/gui_test.py - 4 tests

All tests properly marked with required markers (@pytest.mark.unit, @pytest.mark.integration, @pytest.mark.e2e) ✅


CI/CD Status

Check Status
Lint SUCCESS
CodeQL SUCCESS
SonarQube PASSED (0 issues, 0.0% coverage on new code)
Tests IN_PROGRESS (3 running, 2 queued)
Audit QUEUED

Note: Tests are still running but expected to pass based on:

  • No code changes (only dependency version bump)
  • Stable API interface
  • No breaking changes in release notes
  • Lint and static analysis already passed

Code Quality Checks

No Critical Issues Found

Conventional Commits: ✅ PASS

764493f chore(deps): bump idc-index-data from 22.1.5 to 23.0.1
  • Type: chore
  • Scope: deps
  • Format: Correct ✅

Test Markers: ✅ PASS (all 20 tests properly marked)

Type Checking: ✅ PASS (no changes to code, only dependency version)

Architecture Compliance: ✅ PASS (no code changes)


Recommendations

Approve and Merge

Rationale:

  1. Data-only update - No API surface changes
  2. Backward compatible - Stable interface contracts maintained
  3. Clean release notes - No breaking changes mentioned
  4. Proper testing - 20 tests covering dataset module
  5. CI passing - Lint and static analysis green

📊 Post-Merge Monitoring

While risk is low, monitor these areas after deployment:

  1. Dataset Downloads:

    • Verify IDC v23 collections download successfully
    • Check for any path/filename changes in new data release
    • Monitor aignostics dataset idc download command
  2. Integration Tests:

    • E2E tests with @pytest.mark.e2e covering IDC operations
    • Scheduled tests running against staging environment
  3. Error Logs:

    • Watch for Parquet schema mismatches
    • Monitor IDCClient initialization errors
    • Track s5cmd subprocess failures

Test Commands:

# After merge, verify dataset operations:
uv run aignostics dataset idc collections
uv run pytest -m "e2e and dataset" -v

# Check version detection:
python3 -c "from aignostics.third_party.idc_index import IDCClient; c=IDCClient.client(); print(f'IDC Version: {c.idc_version}')"
# Expected output: "IDC Version: v23"

Medical Device Compliance

No Regulatory Impact

  • No code changes - Only dependency data update
  • No algorithm changes - Data catalog update, not AI/ML model
  • No HIPAA concerns - Public dataset metadata only
  • No FDA submission required - Infrastructure dependency update

Final Verdict

✅ APPROVE - Low-Risk Data Update

This is a routine dependency update for the IDC v23 data release. The package is essentially a data bundle (Parquet index files) with stable API surface. No breaking changes detected.

Action Items:

  • ✅ Merge after CI completes
  • 📊 Monitor dataset download operations post-deployment
  • 🧪 Run E2E dataset tests in staging environment

Questions/Concerns: None identified. This is a standard data release update following semantic versioning where major version tracks IDC data release version.


| Branch: dependabot/pip/idc-index-data-23.0.1

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 22 files with indirect coverage changes

@helmut-hoffer-von-ankershoffen helmut-hoffer-von-ankershoffen added the skip:codecov Skip Codecov reporting and check label Nov 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot Automated pull requests or issues dependabot Pull requests from Dependabot dependencies Pull requests that update a dependency file skip:codecov Skip Codecov reporting and check skip:test:long_running Skip long-running tests (≥5min)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants