Repository navigation
♻️ workflows: align protocols with explicit ports and restart stages - #65
Conversation
25857f3 to
76afabf
Compare
LIU-Binbin
left a comment
There was a problem hiding this comment.
Hi Yiming,
Is it necessary to define a new Restart type? For better integration to other Aiida plugins and easier maintenance, can we try to use Aiida native functionalities, eg the BaseRestartWorkChain, process handlers etc, to realize it?
|
Hi Binbin, I define the RestartType only to encapsulate the relevant parameters into groups so that it is less error-prone because these restart-related parameters are not independent and should always be set consistently. There is also this kind of behavior in aiida-quantumespresso (see https://github.com/aiidateam/aiida-quantumespresso/blob/e90b9ad8d1a857421a1dcf742597bcb48a8ac991/src/aiida_quantumespresso/common/types.py#L36). I think RestartWorkChain can not help with this case. It can only help us to restart the workchain without any modification of the parameters only in cases of system crashes. In the error handling functions, yes we can deal with the parameters control. But as I said, defining a RestartType is only for controlling the parameters into independent groups. It should make the error handling functions more concise (hopefully so). It will not replace the error handling functions. |
323ce8d to
b6245ef
Compare
b6245ef to
c2f9103
Compare
Dependencies
This PR depends on #55 for explicit Eliashberg ports and #58 for
RestartType.Summary
RestartType.Scope
The duplicated #57/#60 parser history and the large Pade fixtures have been removed. This PR contains no
CalculationTypeand does not moveparse_transport_matrices. Parser support from #57 and #60 is a downstream integration dependency, not part of this protocol diff.Validation