Repository navigation
Correct plurality and add amount parameter - #167
Merged
edan-bainglass merged 1 commit intoJul 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 50 50
Lines 2036 2036
=======================================
Hits 1814 1814
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bud-Macaulay
approved these changes
Jul 30, 2026
Bud-Macaulay
left a comment
There was a problem hiding this comment.
LGTM.
Glad you're even fixing the nits that i thought but didnt suggest! Mind-reader. :]
Member
Author
I can also pick nits 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the naming convention w.r.t a few daemon endpoints that are clearly plural in nature. It also adds an
amountquery parameter to the incr/decr endpoints, mirroring the CLI.Requires an update in aiida-rest-client. Will follow up once this is merged!