Skip to content

Correct plurality and add amount parameter - #167

Merged
edan-bainglass merged 1 commit into
aiidateam:masterfrom
edan-bainglass:daemon-worker-endpoints
Jul 30, 2026
Merged

edan-bainglass merged 1 commit into
aiidateam:masterfrom
edan-bainglass:daemon-worker-endpoints

Conversation

@edan-bainglass

@edan-bainglass edan-bainglass commented Jul 30, 2026 •

Copy link
Copy Markdown
Member

This PR corrects the naming convention w.r.t a few daemon endpoints that are clearly plural in nature. It also adds an amount query parameter to the incr/decr endpoints, mirroring the CLI.

Requires an update in aiida-rest-client. Will follow up once this is merged!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.09%. Comparing base (2c174ed) to head (771b711).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          50       50           
  Lines        2036     2036           
=======================================
  Hits         1814     1814           
  Misses        222      222           
Flag Coverage Δ
pytests 89.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bud-Macaulay Bud-Macaulay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Glad you're even fixing the nits that i thought but didnt suggest! Mind-reader. :]

@edan-bainglass

Copy link
Copy Markdown
Member Author

Glad you're even fixing the nits that i thought but didnt suggest! Mind-reader. :]

I can also pick nits 🙂

@edan-bainglass
edan-bainglass merged commit b447e0d into aiidateam:master Jul 30, 2026
5 checks passed
@edan-bainglass edan-bainglass self-assigned this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants