Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin CI/CD to run on ubuntu-24.04 #1269

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Pin GitHub Actions to use ubuntu-24.04 instead of ubuntu-latest.

Assumptions

We prefer stable CI/CD over automatically using the latest OS images.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Jan 18, 2025
@jakob-keller jakob-keller requested a review from webknjaz January 18, 2025 14:22
@jakob-keller jakob-keller self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (ed34a55) to head (5fd8001).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
- Coverage   87.73%   87.38%   -0.36%     
==========================================
  Files          67       67              
  Lines        5905     5905              
==========================================
- Hits         5181     5160      -21     
- Misses        724      745      +21     
Flag Coverage Δ
unittests 87.38% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also started preferring this recently. Though the publishing job would be stable regardless because there's not many system deps in there and most stuff is happening in a container.

@jakob-keller jakob-keller added this pull request to the merge queue Jan 18, 2025
Merged via the queue into aio-libs:master with commit fb860e8 Jan 18, 2025
11 checks passed
@jakob-keller jakob-keller deleted the pin-ubuntu-in-ci branch January 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants