Improve performance of _serialize_headers (#9603)

aio-libs · Nov 2, 2024 · 4108ca5 · 4108ca5
1 parent 898aa28
commit 4108ca5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGES/9603.misc.rst b/CHANGES/9603.misc.rst
@@ -0,0 +1 @@
+Improved performance of serializing HTTP headers -- by :user:`bdraco`.
diff --git a/aiohttp/_http_writer.pyx b/aiohttp/_http_writer.pyx
@@ -127,10 +127,6 @@ def _serialize_headers(str status_line, headers):
 
     _init_writer(&writer)
 
-    for key, val in headers.items():
-        _safe_header(to_str(key))
-        _safe_header(to_str(val))
-
     try:
         if _write_str(&writer, status_line) < 0:
             raise
@@ -140,6 +136,9 @@ def _serialize_headers(str status_line, headers):
             raise
 
         for key, val in headers.items():
+            _safe_header(to_str(key))
+            _safe_header(to_str(val))
+
             if _write_str(&writer, to_str(key)) < 0:
                 raise
             if _write_byte(&writer, b':') < 0:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Improved performance of serializing HTTP headers -- by :user:`bdraco`.