Skip to content

Conversation

@meehand
Copy link
Contributor

@meehand meehand commented Dec 2, 2025

What do these changes do?

Adds regression test for bug that was resolved post-3.13.2

Are there changes in behavior for the user?

None

Is it a substantial burden for the maintainers to support this?

No

Related issue number

Ensures #11778 stays resolved

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #11795 will not alter performance

Comparing meehand:enabled-caching-regression-test (f5282d8) with master (a7b598b)

Summary

✅ 59 untouched

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (a7b598b) to head (f5282d8).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11795      +/-   ##
==========================================
+ Coverage   97.30%   98.73%   +1.43%     
==========================================
  Files         127      127              
  Lines       43823    43845      +22     
  Branches     2332     2332              
==========================================
+ Hits        42643    43292     +649     
+ Misses        959      392     -567     
+ Partials      221      161      -60     
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (+1.31%) ⬆️
OS-Linux 98.33% <100.00%> (+1.05%) ⬆️
OS-Windows 96.68% <100.00%> (?)
OS-macOS 97.56% <100.00%> (?)
Py-3.10.11 97.10% <100.00%> (?)
Py-3.10.19 97.60% <100.00%> (?)
Py-3.11.14 97.80% <100.00%> (+0.68%) ⬆️
Py-3.11.9 97.31% <100.00%> (?)
Py-3.12.10 97.41% <100.00%> (?)
Py-3.12.12 97.90% <100.00%> (+0.67%) ⬆️
Py-3.13.9 98.15% <100.00%> (?)
Py-3.14.0 98.11% <100.00%> (?)
Py-3.14.0t 97.18% <100.00%> (?)
Py-pypy3.11.13-7.3.20 97.40% <100.00%> (?)
VM-macos 97.56% <100.00%> (?)
VM-ubuntu 98.33% <100.00%> (+1.05%) ⬆️
VM-windows 96.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Dec 3, 2025
@Dreamsorcerer Dreamsorcerer merged commit d097058 into aio-libs:master Dec 3, 2025
42 of 44 checks passed
@patchback
Copy link
Contributor

patchback bot commented Dec 3, 2025

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/d097058504374b86c2738c2ebe6f9b445d38ad75/pr-11795

Backported as #11802

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Dec 3, 2025

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/d097058504374b86c2738c2ebe6f9b445d38ad75/pr-11795

Backported as #11803

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 3, 2025
Dreamsorcerer pushed a commit that referenced this pull request Dec 3, 2025
…logging status (#11803)

**This is a backport of PR #11795 as merged into master
(d097058).**

---------

Co-authored-by: meehand <[email protected]>
Dreamsorcerer pushed a commit that referenced this pull request Dec 3, 2025
…logging status (#11802)

**This is a backport of PR #11795 as merged into master
(d097058).**

---------

Co-authored-by: meehand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants