-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added regression test for cached logging status #11795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added regression test for cached logging status #11795
Conversation
CodSpeed Performance ReportMerging #11795 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11795 +/- ##
==========================================
+ Coverage 97.30% 98.73% +1.43%
==========================================
Files 127 127
Lines 43823 43845 +22
Branches 2332 2332
==========================================
+ Hits 42643 43292 +649
+ Misses 959 392 -567
+ Partials 221 161 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.13: 💚 backport PR created✅ Backport PR branch: Backported as #11802 🤖 @patchback |
(cherry picked from commit d097058)
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #11803 🤖 @patchback |
(cherry picked from commit d097058)
…logging status (#11803) **This is a backport of PR #11795 as merged into master (d097058).** --------- Co-authored-by: meehand <[email protected]>
…logging status (#11802) **This is a backport of PR #11795 as merged into master (d097058).** --------- Co-authored-by: meehand <[email protected]>
What do these changes do?
Adds regression test for bug that was resolved post-3.13.2
Are there changes in behavior for the user?
None
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Ensures #11778 stays resolved
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.