[PR #9963/902e7b24 forwardport][3.12] Restore FlowControlDataQueue class
#9965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
fixes aio-libs/aiodocker#918 (cherry picked from commit 902e7b2)
bdraco
changed the title
FlowControlDataQueue classFlowControlDataQueue class
bdraco
changed the title
FlowControlDataQueue classFlowControlDataQueue class
CodSpeed Performance ReportMerging #9965 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #9965 +/- ##
=======================================
Coverage 98.01% 98.02%
=======================================
Files 122 122
Lines 36796 36867 +71
Branches 4429 4438 +9
=======================================
+ Hits 36067 36138 +71
Misses 545 545
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.12/902e7b244c04ba112067362a9f10515830326fa2/pr-9963
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forwardport of PR #9963 as merged into 3.11 (902e7b2).
We no longer use
FlowControlDataQueueinternally as it was removed in #9793. It was assumed (incorrectly) it was not used externally. At leastaiodockeruses it. There may be others so we will restore it for 3.11.Please note that it will go away permanently in 4.x so its will probably be best to vendor the code in this PR if you will still need this class when 4.x is released.
fixes aio-libs/aiodocker#918