Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flat config #3080

Closed
wants to merge 5 commits into from
Closed

Support flat config #3080

wants to merge 5 commits into from

Conversation

Y0g44
Copy link

@Y0g44 Y0g44 commented Jan 25, 2025

This is a pull request to support flat config for eslint-config-airbnb-base and eslint-config-airbnb and do some rewriting.

Example:

// eslint.config.cjs
const airbnb = require('eslint-config-airbnb/flat');

module.exports = [
  ...airbnb,
  // ......
];
// eslint.config.mjs
import airbnb from 'eslint-config-airbnb/flat';

export default [
  ...airbnb,
  // ......
];

@Y0g44
Copy link
Author

Y0g44 commented Jan 25, 2025

By the way, I haven't fully tested it yet. So I'm not sure if it will really work.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m confused, what is the “base” folder? The existing files directly inside rules will remain where they are, and shouldn’t be duplicated.

@ljharb ljharb marked this pull request as draft January 25, 2025 15:22
@Y0g44 Y0g44 requested a review from ljharb January 25, 2025 15:39
@Y0g44 Y0g44 closed this Jan 25, 2025
@ljharb
Copy link
Collaborator

ljharb commented Jan 25, 2025

Why was this closed and replaced with a duplicate #3081?

@Y0g44
Copy link
Author

Y0g44 commented Jan 25, 2025

I tried updating, I'm new to github so I don't really understand how this works. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants