Open
Conversation
added 2 commits
February 22, 2019 13:20
Author
|
I'm not sure how to handle direction here. Maybe we should generate for both? But I'm afraid that will result in a lot of redundant styles. |
Collaborator
|
https://github.com/airbnb/react-dates/blob/master/scripts/renderAllComponents.jsx is still meant to actually render them all, so I don't think it would impact those. |
ljharb
reviewed
Feb 24, 2019
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Perhaps instead of an env var, this could be done with React context?
Author
@ljharb My goal was to have the styles generated as soon as the withStyles block is run, rather than having to render/be involved with React in any way. |
Collaborator
|
Hmm - I wonder if, instead of an env var, we could call an API method on r-w-s to set a flag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To facilitate build-time styles extraction, it would be helpful to add an env or global variable that tells withStyles to create the stylesheet immediately, rather than waiting for the component to be rendered.
This would make things like https://github.com/airbnb/react-dates/blob/master/scripts/renderAllComponents.jsx simpler; rather than having to actually render a bunch of components (and dealing with passing down correct props), just require them.