Memoize WithStylesContextProvider value#236
Open
yepitschunked wants to merge 1 commit intoairbnb:masterfrom
Open
Memoize WithStylesContextProvider value#236yepitschunked wants to merge 1 commit intoairbnb:masterfrom
yepitschunked wants to merge 1 commit intoairbnb:masterfrom
Conversation
ljharb
approved these changes
Jan 15, 2020
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
It’d be good to have some tests if possible, but these things can be tough to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids re-rendering of context consumers whenever the provider re-renders.