fix(demoapps): resolve standalone mode dependency resolution#262
Closed
fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
Closed
fix(demoapps): resolve standalone mode dependency resolution#262fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
Conversation
Fixes demoapps failing to build in standalone mode with error: "Could not find com.airbnb.viaduct:api:." Changes: - Remove dynamic viaductVersion injection via settings.gradle.kts - Add explicit viaduct version in each demoapp's libs.versions.toml - Add version.ref = "viaduct" to all Viaduct library declarations - Remove unused versionCatalogs block that caused empty version resolution For unpublished SNAPSHOTs, users can add mavenLocal() after running publishToMavenLocal from the viaduct root.
fireboy1919
force-pushed
the
fix/demoapp-standalone-versions
branch
from
0a905b8 to
c38d176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Demoapps in standalone mode failed with:
The empty version (
.) was caused byversionCatalogs { create("libs") { version("viaduct", ...) } }not loading the TOML file, and the TOML library entries lackingversion.ref = "viaduct".Solution
val viaductVersion: String by settingsandversionCatalogsblockviaduct = "0.20.0-SNAPSHOT"to each demoapp'slibs.versions.tomlversion.ref = "viaduct"to all Viaduct library declarationsFor unpublished SNAPSHOTs, users can add
mavenLocal()after runningpublishToMavenLocal.Test Plan
- Verified composite mode still works:
- Verified dependency substitution works: dependencies show
fix(demoapps): resolve standalone mode dependency resolution./gradlew :cli-starter:build-> project :apiFixes demoapps failing to build in standalone mode with error
"Could not find com.airbnb.viaduct:api:." by adding explicit
viaduct versions to TOML files and removing broken dynamic
version injection.