Skip to content

Commit

Permalink
Fix: Normalize schema names for correct name comparison (#296)
Browse files Browse the repository at this point in the history
  • Loading branch information
nakamichiworks authored Aug 10, 2024
1 parent 94681b0 commit 2aa9399
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions airbyte/_future_cdk/sql_processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,13 +305,13 @@ def _get_table_by_name(
def _ensure_schema_exists(
self,
) -> None:
"""Return a new (unique) temporary table name."""
schema_name = self.sql_config.schema_name

if self._known_schemas_list and self.sql_config.schema_name in self._known_schemas_list:
schema_name = self.normalizer.normalize(self.sql_config.schema_name)
known_schemas_list = self.normalizer.normalize_list(self._known_schemas_list)
if known_schemas_list and schema_name in known_schemas_list:
return # Already exists

if schema_name in self._get_schemas_list():
schemas_list = self.normalizer.normalize_list(self._get_schemas_list())
if schema_name in schemas_list:
return

sql = f"CREATE SCHEMA IF NOT EXISTS {schema_name}"
Expand All @@ -324,7 +324,7 @@ def _ensure_schema_exists(
raise

if DEBUG_MODE:
found_schemas = self._get_schemas_list()
found_schemas = schemas_list
assert (
schema_name in found_schemas
), f"Schema {schema_name} was not created. Found: {found_schemas}"
Expand Down

0 comments on commit 2aa9399

Please sign in to comment.