Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle DECIMAL(38,9) type conversion in BigQuery processor #582

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix BigQuery DECIMAL(38,9) type conversion

This PR fixes the issue where BigQuery cache operations fail with "Invalid value for type: DECIMAL(38, 9)" error by properly mapping SQLAlchemy DECIMAL types to BigQuery's NUMERIC type with appropriate precision and scale parameters.

Changes:

  • Added explicit handling of DECIMAL types in BigQueryTypeConverter
  • Maps SQLAlchemy DECIMAL to BigQuery NUMERIC(38,9)

Testing:

  • Manual testing needed to verify the fix works with actual BigQuery cache operations

Fixes #573

Link to Devin run: https://app.devin.ai/sessions/a5b1089b2e6749039d54de93a56e7c39

Copy link
Contributor Author

Original prompt:

@Devin - Can you investigate this one? Per the reporters most recent comment, we should be able to use the pre- and post-manifesting version diff for clues. <https://github.com/airbytehq/pyairbyte/issues/573>

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@aaronsteers aaronsteers marked this pull request as ready for review January 24, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache BigQuery: Invalid value for type: DECIMAL(38, 9) is not a valid value
0 participants