Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip source-faker tests on Python 3.12 (do not merge) #609

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

test: skip source-faker tests on Python 3.12 (do not merge) #609

wants to merge 12 commits into from
+263 −154

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Skip source-faker integration tests when running on Python 3.12 since source-faker is not yet compatible.

Link to Devin run: https://app.devin.ai/sessions/439aca1186b74246acfce476da1889b1
Requested by: Aaron

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - PyAirbyte supports Python 3.12 but source-faker doesn't (yet). And source-faker is used in PyAirbyte's integration tests. Can you add a pytest conditional 'skip' mark so that source-faker incompatibilities don't fail PyAirbyte's tests on Python 3.12?

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot mentioned this pull request Feb 11, 2025
Open
@aaronsteers
Copy link
Contributor

aaronsteers commented Feb 11, 2025 •
edited by github-actions bot
Loading

/poetry-lock

poetry lock job started... Check job output.

✅ poetry lock applied successfully.

@aaronsteers aaronsteers marked this pull request as ready for review February 11, 2025 19:29
@aaronsteers aaronsteers enabled auto-merge (squash) February 11, 2025 19:30
@devin-ai-integration devin-ai-integration bot mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aaronsteers